This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-04-24
Channels
- # aws-lambda (1)
- # beginners (99)
- # boot (46)
- # cider (8)
- # cljs-dev (20)
- # cljsrn (37)
- # clojure (189)
- # clojure-dev (22)
- # clojure-dusseldorf (28)
- # clojure-italy (1)
- # clojure-russia (28)
- # clojure-spec (10)
- # clojure-uk (33)
- # clojurebridge (1)
- # clojurescript (64)
- # core-matrix (2)
- # css (3)
- # cursive (3)
- # datascript (34)
- # datomic (101)
- # defnpodcast (2)
- # dirac (5)
- # events (1)
- # funcool (3)
- # ldnclj (1)
- # lumo (11)
- # mount (1)
- # off-topic (95)
- # pedestal (2)
- # perun (10)
- # re-frame (3)
- # reagent (6)
- # ring-swagger (4)
- # specter (102)
- # test-check (1)
- # untangled (1)
- # vim (8)
- # yada (17)
@jfntn sounds like a useful enhancement - there’s no particular reason that info isn’t there
@dnolen any objections to replacing cljs/nodejs_externs.js
with https://github.com/google/closure-compiler/blob/master/contrib/nodejs/globals.js ?
@dnolen right now defmacro
returns true
even when :def-emits-var
is true. This is because set!
is the last statement we invoke
(see https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/core.cljc#L3125)
shouldn’t we return the result of defn
for REPLs that want to show the var?
great
definitely not something that I would have encountered had I not been working on Lumo
just wanted to check if a patch would be welcome
@anmonteiro yep, go for it
@dnolen thanks, fixed in https://dev.clojure.org/jira/browse/CLJS-2015
So I dug a bit into the externs inference code; as far as I can tell, the bits that make *warn-on-infer*
work correctly with :externs
being set are only enabled through code paths that hit closure/build
, so calling the analyzer API directly will only work with the gclosure builtin externs