Could what Gradle does here be useful for ClojureScript? https://blog.gradle.org/incremental-compiler-avoidance

Compile avoidance avoids recompiling consuming namespaces if the public API of a function hasn't changed

@danielcompton to summarize the approach there: the compiler analyzes the exposed API (e.g. top level defs) and only recompiles dependents if the exposed (top-level) API has changed?

Yeah that's my understanding

And similarly for incremental recompiles, it only recompiles namespaces that a) depend on the changed namespace, and b) used part of the public API that changed

Seems like https://clojurescript.org/guides/javascript-modules does not works with deps.cljs, is that expected?

@niwinz expected

since there’s no way to install that stuff

I'm not clearly understand that you saying. I'm asking for use of :foreign-libs (with module transformations) from deps.cljs. I found that it works if I pass :foreign-libs to the compiler, but raises an exception (like "src" is a directory) if I use the same options but from deps.cljs

@niwinz I do understand

you’re talking about an alpha thing - don’t expect much to work

😉 ok

@danielcompton that’s interesting but we might want to see what happens to spec first

I noticed a bug in cljs.test where we assume the output path for files to be in something /out/, when this is not the case it fails to get the file name for the test report. https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/test.cljs#L379

I can put a ticket together and patch but thought I would post it here first.

I ran across this with a client that pushed their code to js/compiled

@ckirkendall patch welcome

cool I was thinking just pull the last two directories above the file if they exist.

since the full path seems problematic given we don’t know the starting point

I can also detect ‘/out/’ and leave the current behavior as is if it is detected.

@ckirkendall I don’t think that approach is desirable

just get it from the compiler options

you mean get the out location directly from compiler options?

hrm actually I think this functionality is already too vestigial

this won’t handle different JS environments

there’s a namespace that does all this work already

cljs.stacktrace

yeah I have all ready noticed a few other issues with it also

ok

I noticed that for most tests I never get any file other than cljs/test.js

async tests I get the actual file

hrm yeah I don’t know

I haven’t looked at this stuff in ages

was expecting other people to help out with it - was a pain the butt to do 🙂

all good I may get a chance this week to sit down and look at it.

but feel free to open a ticket

will do

would be nice for the issue to not get lost regardless of the solution