Clojurians
#cljs-dev
<
2016-06-07
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes02:06:45

With non-edn cropping up in the analysis cache it makes me even more curious what would happen if we had a spec for it

dnolen12:06:10

@mfikes would also be interesting to do that for the AST

dnolen12:06:24

would be useful for would be compiler hackers

dnolen12:06:45

heck, even for us who work on it all the time

mfikes13:06:38

One thing I liked about Bensu’s records was that it gave a little explicit structure that you could look at. Perhaps spec is a more direct way to do that. :slightly_smiling_face:

anmonteiro16:06:34

@dnolen: are the new clojure predicates coming to CLJS as well? (the ones that make sense, ofc)

dnolen16:06:36

@anmonteiro: yes, if someone wants to make a patch I’m happy to apply it

dnolen16:06:39

should be pretty straightforward

anmonteiro16:06:58

@dnolen: I can do it but I think it’s better to wait at least until the alpha is released?

dnolen16:06:13

@anmonteiro: there’s no need to wait

dnolen16:06:29

I probably won’t cut a release till after the next Clojure alpha anyway

dnolen16:06:45

need to fix the transit cache issues, so probably Friday at the earliest

pat19:06:03

@dnolen are you open to a predicates test ns like in clojure?

dnolen19:06:24

@anmonteiro: already offered to port those

dnolen19:06:51

and yes pretty much anything added to Clojure around clojure.spec is on the table for ClojureScript cljs.spec

pat19:06:25

sorry i didnt read the thread, just signed on

anmonteiro19:06:19

@pat: go ahead and make the patch if you want

anmonteiro19:06:42

I’ve been busy so I haven’t even opened the JIRA issue

pat19:06:55

are you sure? I havent written anthing yet

anmonteiro19:06:45

yea go ahead

dnolen19:06:30

@pat do you have your CA filed?

pat19:06:22

@anmonteiro: thanks will do @dnolen yes

dnolen19:06:26

cool then go for it, would prefer to get a patch that simply covers all of Clojure commit 58227c5

dnolen19:06:41

over anything piecemeal

pat19:06:41

Including spec stuff?

pat19:06:53

i ask only because I haven't studied it yet, but i'll take a crack at it

dnolen19:06:51

@pat that’s really the only thing I’m interested in

dnolen19:06:54

the entire commit

dnolen19:06:41

fortunately there’s not too much study here, mostly just copy and pasting into the appropriate spots

dnolen19:06:56

that is this doesn’t really require understanding how spec works

dnolen19:06:05

if you do have a question about something, ask it’ll likely be simple

dnolen20:06:25

@pat thanks, I fixed your permissions in JIRA you should be able to do whatever you need to that ticket (or any other ticket)

pat20:06:11

awesome thankyou