Fork me on GitHub
#cljdoc
<
2022-11-20
>
slipset13:11:49

I just released org.clj-commons/hickory and got the build running on cljdoc, which is awesome! I do see however that if I click on the link for core from https://cljdoc.org/d/org.clj-commons/hickory/0.7.2/api/hickory.zip I get an error. Is this me or is it cljdoc?

lread16:11:44

I too see "An exception occurred, sorry about that!" when clicking on the hickory.core link. This seems like a cljdoc issue to me. I shall take a peek at what is going on sometime today.

lread17:11:43

@slipset, I had a quick peek. Cljdoc is intentionally barfing on HiccupRepresentable protocol members being different between clj and cljs at render time. The clj https://github.com/clj-commons/hickory/blob/bef62d990d070868bb2181413b80c4d2e1c23fbf/src/clj/hickory/core.clj#L20-L26 supports arglists [this] and [this zip-loc] . The cljs https://github.com/clj-commons/hickory/blob/bef62d990d070868bb2181413b80c4d2e1c23fbf/src/cljs/hickory/core.cljs#L11-L17 supports only [this] arglists. I don't yet know the history/rationale for this cljdoc behaviour. I will start with raising an issue on cljdoc.

lread20:11:08

@slipset cljdoc now deals with platform differences in protocol members. The https://cljdoc.org/d/org.clj-commons/hickory/0.7.3/api/hickory.core#HiccupRepresentable namespace should no longer error out. Thanks for letting us know we had a problem here!

slipset20:11:24

Excellent! Thanks a lot for fixing it 💜