Fork me on GitHub
#cljdoc
<
2021-08-20
>
lread12:08:46

Awesome @deleted-user! Woot woot!

partywombat 2
martinklepsch13:08:39

Exciting @deleted-user! I missed your typescript PR in my notifications but on the flipside I’m very happy I seem to not be blocking anyone 🙂

lread13:08:10

One thing I find very interesting about cljdoc @martinklepsch, is your choice to allow any past contributor to merge their own PRs, effectively making them live. It is at first terrifying, then eventually, empowering!

lread13:08:50

I like that I can ask for a review if I feel I want/need it, but am also free to make a change go live.

martinklepsch13:08:33

I got the idea of giving push access from a nodejs contributor many years ago: https://felixge.de/2013/03/11/the-pull-request-hack/

martinklepsch13:08:57

The fact that that means you can also deploy to http://cljdoc.org is just a “happy accident” in a way haha

martinklepsch13:08:20

Hey! no worries at all 🙂

martinklepsch13:08:41

I just spent too much time at work fixing a cypress test suite (likely not cypress’ fault) 😂

lread13:08:09

Fascinating that this push access strategy works! I don't see a case where it backfired yet.

lread13:08:25

Personally I've found automated browser based testing too brittle and too much work to maintain and have relied on them only for minimal smoke tests, if that.

martinklepsch13:08:34

You just gave me an idea for a blog post, thanks! 🙂 (on the push access stuff)

lread13:08:22

Ya great idea!

lread13:08:27

True dat, nor does it have a big complicated ui.

lread13:08:42

@martinklepsch for your blog post, there are some projects where this won't work, right? You have to be willing to give up control. I mean imagine this strategy applied to Clojure core.

martinklepsch13:08:39

@lee yeah, I think that’s kind of the interesting piece about it. with cljdoc we can be “chill about breakage” (mostly because there isn’t really an API)

lread13:08:12

Maybe more suited to apps than libs?

martinklepsch13:08:20

obv. there’s also limits and considerations to that, we don’t want to break anyone’s workflow, but overall it’s much more forgiving than library stuff

lread13:08:41

Cool, looking forward to reading your blog post!

lread13:08:28

The dynamics are interesting too. Like I could have pushed that Sass change way back when. But I knew it was controversial. I knew to ask for the opinion of the project lead. And was ok with putting the decision to push into the team lead's hands. And was ok with accepting the team lead's decision. I suppose this would break down if you had some problematic individual, but that just doesn't seem to have happened.

martinklepsch13:08:31

yup pretty much

martinklepsch14:08:25

not gonna get an award for the most edited, well structured, thoughtful writing but I’m in a place where I just want to hit “publish” on more things 😄

catjam 4