Fork me on GitHub
#cljdoc
<
2020-06-05
>
dominicm09:06:50

@tony.kay I think tick does depend on cljsjs

dominicm09:06:57

It just uses the foreign libs

martinklepsch09:06:07

Check the latest commits in cljdoc/cljdoc-analyzer and feel free to add any JS deps in the same fashion. This recently fixed the issue for Pathom. @tony.kay @danvingo

martinklepsch09:06:25

We’re already automatically detecting this now for string requires inside the analyzed project but it’s obviously more involved to do for the the entire classpath (but I guess it would be possible)

dominicm10:06:11

I think the right way to populate that list is by looking at deps.cljs

dominicm10:06:09

https://github.com/cljsjs/packages/blob/master/d3/build.boot#L25-L26 You need to find deps.cljs files, and look for their :provides in order to determine what js deps they need.

dominicm10:06:50

@martinklepsch Been a while since I read the code, does the analyzer have access to the classpath of the lib?

martinklepsch10:06:38

Yeah that might be a good approach. The analyzer does have access to the full classpath

tony.kay12:06:53

But if you’re not using cljsjs, and instead getting things from npm directly, classpath doesn’t help you.

martinklepsch12:06:42

That’s where the commit above helps

tony.kay13:06:24

I need to review the ecosystem story for how we are doing transitive npm deps (i.e. are we?)…as a library maintainer I should really know that

tony.kay13:06:48

too few hours in a day

dominicm14:06:54

If you're compatible with an npm dependency in your library, then you might have :npm-deps in your deps.cljs.