Fork me on GitHub
#clj-kondo
<
2022-01-22
>
mknoszlig20:01:24

sneak preview of task cycle detection in babashka’s bb.edn

🎉 4
mknoszlig20:01:46

i’m not sure yet whether it’s better to show the same order in the cycle path (as above), or make it relative to the currently highlighted task

mknoszlig20:01:31

also: currently only detects one cycle at a time if there’s more than one

borkdude20:01:52

just the first cycle is enough

borkdude20:01:21

I think it would be the most logical to show the cycle starting with the task you are in?

borkdude20:01:35

but it's not that important, as long as you see a cycle warning

mknoszlig20:01:51

i think that wouldn’t be too much additional work

borkdude20:01:35

b {:depends [^here]}
would warn about cycle b -> ...

mknoszlig20:01:55

yep, basically just anchoring the displayed path on the “active” task. my only concern is that if it’s used in another mode than interactive it’ll be harder to identify as essentially the same warning?

borkdude20:01:29

optimize for editor experience I would say

borkdude20:01:46

people are going to look into the code anyway to see what's wrong

mknoszlig20:01:15

true. i’ll give it a shot. thanks for the feedback 🙂

❤️ 1