OK I quit clojure and re-opened it and now it works

oh it's the same repl where I redefined let

dw thats why

as one does 😆

Lispers hold inalienable the right to shoot off our own toes. Welcome to the club.

(ns server
  (:require cheshire.core
            [compojure.core :refer [defroutes GET POST]]
            [compojure.route :as route]
            [ring.adapter.jetty :as jetty]
            [ring.middleware.json :refer [wrap-json-response wrap-json-body]]
            [ring.middleware.params :as params]))


(defn add-question [request]
  {:satus 200
   :headers {}
   :body {:body (:body request)
          :params (:params request)}})

(defroutes app-routes
  (GET "/" [] "Hello World")
  (POST "/api/srv/question" [] add-question)
  (route/not-found "Not Found"))

(def app (-> app-routes
             params/wrap-params
             wrap-json-response
             wrap-json-body))

(comment
  (def server (jetty/run-jetty #'app {:port 4000 :join? false}))
  (.stop server)
  )

i’ve added a few other things here. wrap-json-response will make maps returned be serialized into json. and wrap-json-body will parse the body of requests with an application/json content-type into a clojure datastructure

and the crux of it is that you are sending the data over as the body of the request. It’s not a parameter of the request

❯ curl --data '{"A": "huhu"}' --header 'Content-Type: application/json' ""
{"body":{"A":"huhu"},"params":{"params":"here"}}%

I’m returning a map with two keys: • "body": This has the payload sent over • "params" this has the params from the route. (note my route is api/srv/question?params=here)

deps required for these:

{:deps {ring/ring {:mvn/version "1.9.6"}
        compojure/compojure {:mvn/version "1.7.0"}
        ring/ring-json {:mvn/version "0.5.1"}
        cheshire/cheshire {:mvn/version "5.11.0"}}}

FYI what you are destructuring in add-question (before @U11BV7MTK changes) are the query parameters passed to the URI not the body of the request (sent in the cURL -d option). So if you did this:

curl -X post ""
{"A":"huhu"}

The query params are key value pairs following the ?

I believe it also includes route params. Like if your route was api/srv/question/<question-id> you would have the question id in the params map as well

Ok, thank you very much @U11BV7MTKand @U05390U2P you helped me a lot here. I cannot tell you, why I missed something here, or what it was. I also was aware that params and body are diffferent things, but ring-documentation was a bit confusing in some paragraphs... any, I struggeled, because I constantly got an

:body #object[org.eclipse.jetty.server.HttpInputOverHTTP 0x
5f126a6c HttpInputOverHTTP@5f126a6c]

why is it gone now? and how could I handle a inputOverHttp, seems to be a stream, also tried to play around with io/stream-reader... you see I dived in a big sea there 😄

but maybe it also was a side-effect of using wrap-defaults with site-defaults.... have to dig around a bit

I tried a lot there, also using api-defaults http://et.al.

anyways: thanks a lot, your example here works perfectly fine for me so far, thank you!

You can do the lazy work inside of the with-open before the stream is closed

If you macroexpand with-open, you'll see that it will close the reader before the function returns.

(clojure.core/let
 [rdr (io/reader file-pathname-string)]
 (try
  (clojure.core/with-open [] (line-seq rdr))
  (finally (. rdr clojure.core/close))))

^ that's a better answer 🙂

It's usually fine to use doall in cases like these. The main exception is if the file is large and you don't want to hold the full contents of the file in memory. In those cases, you can do as @U6T7M9DBR suggests and do the processing inside.

I think processing a file line by line is a good use case for transducers. something like:

(defn transduce-lines [xform f init fname]
  (with-open [rdr (io/reader fname)]
    (transduce
     xform
     f
     init
     (line-seq rdr))))

;; count characters
(transduce-lines
 (map count)
 +
 0
 (io/file "deps.edn"))

I was just thinking on the drive home whether or not I could use a transducer here. That seems like a good approach

Thanks all

you don't need a transducer, even though it may be the better solution. to me the main idea in the transducer code is that you are processing the whole file in the fn, and one of the params is the transformation/behaviour. you can do this with or without a transducer, just make sure that your file processing function follows the same guidelines.

Yes, you'll get more polite and more in-depth answers here as folks have opted in to helping folks who are new to Clojure/Script.

I think you're missing some parens and it's just returning the last form

> (filter empty? '((1, 2, 3), (), (4, 5, 6)))
(())

O_O Yeah, just noticed. I have to look better. Thanks!

Try https://www.maria.cloud/