you can use martian + babashka.http-client

i.e which of these should I use:

https://cljdoc.org/d/com.github.oliyh/martian-babashka-http-client/0.1.25/doc/readme

if it's not listed in that list, provide a PR to martian

(cc @U076R6N1L)

@U4C3ZU6KX I tested this and it works:

(babashka.deps/add-deps '{:deps {com.github.oliyh/martian-babashka-http-client {:mvn/version "0.1.25"}}})

Thanks

I have sort of got it working, but I have hit the normal issues of :insecure (I have tried to add a client into the ctx but not sure if that is the correct way to handle it. Also I am getting errors, from the library and I was wondering where I could ask questions. Can't find a #martian channel.

The author is @U076R6N1L - perhaps we can ask him to create a martian channel, but feel free to continue here as well. As for creating a separate client, makes sense. Let's have a look at the source...

@U4C3ZU6KX If you would add :client here: https://github.com/oliyh/martian/blob/2540b6273b32a099ce9632a68115c6d83da83890/babashka-http-client/src/martian/babashka/http_client.clj#L13 then a custom client would work

I think you would need to pass ctx as well and add :client from ctx to the request map

@U4C3ZU6KX you could experiment locally with this and use the martian "plugin" as a :local/root project in in bb.edn, let me know if you need any help

Hi, I can have a look at this a bit later on. There is no #martian channel, happy to chat on this thread

Have you got it working using the BB http client directly?

@U076R6N1L one issue is that the README of the martian project does not list:

com.github.oliyh/martian-babashka-http-client 

the other issue, being able to pass a custom client, is another one. not sure if you've done something similar for the other clients?

Yep I will add the babashka sub library to the readme!

What do we mean by custom client here? Is that a babashka-http thing?

yes, but also a concept that is known to other http libraries like http-kit and clj-http

Ok like the connection manager thing

I have a DM with @U4C3ZU6KX but will share the answer back here once we've got it sorted

with the clj-http you can pass "load-opts" which get later merged when doing a request. https://github.com/oliyh/martian/blob/2540b6273b32a099ce9632a68115c6d83da83890/clj-http/src/martian/clj_http.clj#L22-L31 This would also be a good solution for the bb client lib

Then you can just pass :client ... as part of the load-opts

actually I think that should already work as of now

without any changes

The load-opts are only for loading the swagger json

ah ok

The entire request map in the context is passed to the http library, so you can write an interceptor to put anything you want in there

cool, the only thing is when bootstrapping also a request is made

so you should still pass the client through the load opts as well

Yeah, that's why load opts is special, because that happens before you have an instance, therefore no interceptors yet

the load-opts are merged with the request so this should work

I need to check if all the other ones work the same way, they should. And yes, that's how you do it for loading the swagger json. After that, you can write an interceptor like this

(fn [ctx]
  (assoc-in ctx [:request :client] your-client-thing))

ok, @U4C3ZU6KX ^

Thanks guys.

Perhaps adding some docs about this would be good, if you can verify that it works for you

I still get

; clojure.lang.ExceptionInfo: unable to find valid certification path to requested target mexp.core tripod/context.cljc:207:7

what did you do exactly

I would make sure you can get the request working in the http client directly first

The snippet from my code

(def client (http/client (assoc-in http/default-client-opts [:ssl-context :insecure] true)))

(def allow-insecure
  {:name ::allow-insecure
   :enter (fn [ctx]
            (assoc-in ctx [:request :client] client))})

(def add-authentication-header
  {:name ::add-authentication-header
   :enter (fn [ctx]
            (assoc-in ctx [:request :headers "Authorization"] "Token: <token str>" ))})

(def m (martian/bootstrap-openapi (str "https://" (:cpd-route (u/get_config (u/get-user))) "/api/v2/catalog")
                                  (mf/load-local-resource "resources/descriptors.yaml")
                                  {:interceptors (concat martian/default-interceptors
                                                         [add-authentication-header
                                                          allow-insecure
                                                          martian-http/perform-request])}))

(martian/response-for m :get-descriptors)

output:

No matching content-type available {:supported-content-types #{}, :available-content-types (application/json), :header Content-Type}
No matching content-type available {:supported-content-types #{}, :available-content-types (application/json), :header Content-Type}
; clojure.lang.ExceptionInfo: Exceptional status code: 404 mexp.core tripod/context.cljc:207:7

you need to add :client client to the load-opts for the bootstrap thing as well

https://github.com/oliyh/martian/blob/2540b6273b32a099ce9632a68115c6d83da83890/babashka-http-client/src/martian/babashka/http_client.clj#L91 the last argument

Isn't that what I have done in the allow-insecure?

just do it

add {:interceptors ... :client client}

Ok thanks

did that work?

When adding it through the interceptor I no longer get the message about the certificates, but I get a 404 which means I got through. so the following seemed to work ok

{:name ::allow-insecure
   :enter (fn [ctx]
            (assoc-in ctx [:request :client] client))})

The http-kit client should also work with bb btw and clj-http-lite as well, so you have more options.

as @U076R6N1L suggested, just trying to load the swagger docs using a bare minimal example using only the client might be good to try

Ok thanks

That @U04V15CAJ, I am afraid I could not get the Authentication to work with the martian-babashka-http library so I swap to clj-http-lite and it works. The insecure set up with the client worked, so that was good. Just struggle to get oauth token injected. I wish I understood more to take load off you. Hope you have a good weekend.

no worries, and thanks!

i updated the martian readme to hopefully make the http-client library choice easier to understand: https://github.com/oliyh/martian/blob/master/README.md