yeah I also found that logic a bit rage-inducing… saved one line — bravo

Running metabase and connecting to a socket repl

❯ netcat localhost 51345
shadow-cljs - REPL - see (help)
To quit, type: :repl/quit
shadow.user=> (shadow/node-repl)
cljs.user=> shadow-cljs - #5 ready!
(require 'metabase.util.log-test :reload)
nil
cljs.user=> (require 'metabase.util.log-test :reload) ;; run twice no error
nil
cljs.user=> (in-ns 'metabase.util.log-test)
nil
metabase.util.log-test=> (logf-formatting-test)
[metabase.util.log-test] "input: 8, 3; output: ignored"
nil
metabase.util.log-test=> (require 'metabase.util.log-test :reload)
------ REPL Error while processing ---------------------------------------------
(require 'metabase.util.log-test :reload)
no source by provide: metabase.util.log-test
{:provide metabase.util.log-test}
ExceptionInfo: no source by provide: metabase.util.log-test
	shadow.build.data/get-source-id-by-provide (data.clj:192)
	shadow.build.data/get-source-id-by-provide (data.clj:187)
	shadow.build.data/get-source-by-provide (data.clj:195)
	shadow.build.data/get-source-by-provide (data.clj:194)
	shadow.build.resolve/resolve-repl (resolve.clj:725)
	shadow.build.resolve/resolve-repl (resolve.clj:719)
	shadow.cljs.repl/repl-require (repl.clj:223)
	shadow.cljs.repl/repl-require (repl.clj:187)
	shadow.cljs.repl/process-read-result (repl.clj:530)
	shadow.cljs.repl/process-read-result (repl.clj:510)
	shadow.cljs.repl/process-input (repl.clj:673)
	shadow.cljs.repl/process-input (repl.clj:651)
	shadow.cljs.devtools.server.worker.impl/eval17570/fn--17573 (impl.clj:698)
	clojure.lang.MultiFn.invoke (MultiFn.java:234)
	shadow.cljs.devtools.server.util/server-thread/fn--17210/fn--17211/fn--17219 (util.clj:283)
	shadow.cljs.devtools.server.util/server-thread/fn--17210/fn--17211 (util.clj:282)
	shadow.cljs.devtools.server.util/server-thread/fn--17210 (util.clj:255)
	java.lang.Thread.run (Thread.java:833)

i can require the namespace several times, then switch to the namespace, run a test. But if i require :reload from the namespace itself I get an error

I’m running shadow with :deps {:aliases [:cljs]}, and that alias is

:cljs
  {:extra-paths ["test" "shared/test"]
   :extra-deps
   {binaryage/devtools                 {:mvn/version "1.0.6"}
    cider/cider-nrepl                  {:mvn/version "0.30.0"}
    cider/piggieback                   {:mvn/version "0.5.3"}
    cljs-bean/cljs-bean                {:mvn/version "1.9.0"}
    com.lambdaisland/glogi             {:mvn/version "1.2.164"}
    io.github.metabase/hawk            {:sha "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"}
    ;; Forcibly targeting a newer release than ships by default with shadow-cljs 2.20.20.
    ;; It fixes an issue where TypeScript can't parse the `cljs_env.js` output file.
    org.clojure/google-closure-library {:mvn/version "0.0-20230227-c7c0a541"}
    refactor-nrepl/refactor-nrepl      {:mvn/version "3.6.0"}
    thheller/shadow-cljs               {:mvn/version "2.21.0"}}}

digging into the compiler state, the error says it is not finding the provide (the namespace symbol) in the :sym->id map Looking at the contents of that, that seems to omit the current namespace. So i can require :reload other namespace, and if i require another namespace then the current namespace shows back up

I also think that it’s using my require forms in the repl and adding those to a dependency graph. It thinks that I’m adding a require to the other namespace and then switching around makes it warn about circularity

hmm could be wiping too much or not enough from the compiler-env due to the :reload

I never use require re-load, load-file is much more reliable

but should work regardless

why do you say that? I use :reload in clojure repls. And that ensures that all of the metadata is set correctly on vars (line numbers and such) so doc and friends work. So I prefer that route. But wondering why you prefer load-file

the require creating a circular require is known, currently there is no separation of requires added by the REPL or code

ok. is that a feature request i can add or just a known limitation of the internals?

this should work fine. I cannot immediately tell you why it doesn't

just saying that load-file might not have that issue 😛

(which is what cursive uses, so I guess that why I never end up with require)

(i meant about the circular require issue). I’ll switch to load-file 🙂 . Happy to create any issues that you are interested in tackling (making require work correctly at the repl, the circularity bug, etc)

yes, feel free to open an issue. there is already one for the circular dependency though

so keep it to the reload thing

thanks much

https://github.com/thheller/shadow-cljs/issues/1027

https://github.com/thheller/shadow-cljs/issues/1091

thanks for your help