Could you share the benchmark code? Would be nice to have around!

hello @thheller, I think the documentation regarding nrepl middleware needs to be updated. including the latest shadow-cljs with no nrepl exclusions, you need to use shadow.cljs.devtools.server.nrepl04/... middleware for things to work, and the documentation just mentions the old version https://shadow-cljs.github.io/docs/UsersGuide.html#_embedded_nrepl_server

yeah. I can probably remove the old implementation now. or rather just flip it. nobody should be using .nrepl04 directly

i create a project from luminus, and then i try to change its cljsbuild to shadow-cljs, and its dependencies by deps.edn, but when i execute shadow-cljs compile app, it show warnning, i don’t know what’s this means

@thheller i follow your example https://github.com/thheller/lumifoo, but i don’t know how to fix this

@thheller this is my repo, https://github.com/vinurs/admin could u help me?

@haiyuan.vinurs you need to fix your source path

From maybe “src” to”src/cljs”

in the shadow-cljs.edn, i set this

Yes :src I think, at my phone so dont remember

Or :source-paths

The namespace represent the filepsth starting the the root of the innermost source path

Oh could you paste the result of “tree ./src” in the shell?

Wait you have lein true and use deps?

yes

Change :lein true to :deps true

because i want to share deps with lein and shadow-cljs

Or no wiat

Add :src into your deps.edn file

:lein true :deps {:aliases [:cljs]}

this is what i’ve set in shadow-cljs

And there same as you have in :source-paths

Deps is in control of the source path if you use it

:source-paths [“src/cljc” “src/cljs” “env/prod/cljs”]

Because source path is actually classpath, and deps takes care of tje classpath

Yes put this in deps.edn

it has been there

Not in the file you sent above, or I am terribly blind

https://github.com/vinurs/admin

You have :deps and :aliases

the test i’ve push to the github

yes

But youre missing source patha

so , i need to set paths in the deps.edn?

Yes, if you have deps.edn take care of the deps, shadow wil hand over the responsibility of classpath to depsedn

Same with leiningen I assume.

But preferably yu should have lein and shadow point to deps.edn but thats maybe a matter of taste

As far as i remember its :paths not :source-paths

In deps.edn

because some times cljs and clj need the same library, so i want to share deps between clj and cljs, that is lein and shadow-clj, so i use deps.edn

Yes thats good thinking, but the :lein true you have in shadow-cljs.edn seems redundant to me

Just use :deps true instead and use in leiningen the deps middleware

i changed, but it does no effect

Cant be :) you have now :paths :aliases and :deps in deps.edn?

ok now

set this in deps.edn

but, i think this should be cljs only, so i set it in the alias :cljs

Nana its fine that its global

and in shadow-cljs i use :deps {:aliases [:cljs]}

Uhh its really unneccecary

but now it’s global, so in lein, the paths will auto import? does it conflict with clj’s src/clj?

No because you can only have 1 compiler reading at any given time. Cant have clj and cljs running as 1 compiler

but in project.clj, i have this setting: :source-paths [“src/clj” “src/cljc”]

oh, i see, the clojure compiler doesn’t read cljs file

Ok. You dont want deps edn to take care of the deps for leiningen then?

actually, i do want, but i don’t know how to set seperately for clj and cljs, so i set in project.clj before

Look at the leiningen deps middleware/plugin. Then you dont neeed to set classpaths in leiningen, 1 source of truth for both shadow and lein, that would be clean

[lein-tools-deps “0.4.5”]

i use this

Ah yeh i see now you have it setup right. If you give me 10 mins I can run your app

But need then to add the resource path to deps edn too

Thats lein side tough, your problem is with cljs source path

yes, i want to move all deps to deps.edn

some deps are cljs only, is there anyway i can seperate it from global?

i read the doc, and found aliases

sorry long 10 minutes, testing now

thanks

@haiyuan.vinurs its taking some time, are you using leiningen to generate the index.html?

yes

Caused by: java.lang.RuntimeException: could not find a non empty configuration file to load. looked in the classpath (as a "resource") and on a file system via "conf" system property

Hello How do I handle local clojurescript dependencies with shadow-cljs? I.e. I have foo/shadow-cljs.edn and a bar/shadow-cljs.edn, and want bar to depend on foo. If this was leiningen, I'd go into foo and do lein install, then that would copy the artifact to my local maven cache, and I would depend on it from bar normally. Is there a shadow-cljs equivalent?

i mv the resource dir to deps.edn

I remove the jvm opts and sass, dont have sass

(I dont..)

@polymeris I'd use leiningen for this usecase to create a jar

@haiyuan.vinurs Caused by: java.lang.RuntimeException: could not start [#'admin.config/env] this is beyond the scope of shadow-cljs, I'll just create a index.html, confirm if the paths are correct, then you can ask for lein question on different channel

ok

the code i pushed to the github works well in my pc

now, the problem is that, when i in emacs cider-jack-in, then it start a nrepl, and then in terminal, i type: shadow-cljs watch app, then in chrome i visit http://127.0.0.1:3000/, but it shows

it seems that the compiled app.js doesn’t affect

but the js has been there

there is app.js in my home.html

ignore the html, but shadow-cljs is working fine

ok make sure you don't have any figwheel or anything connected to clojurescript operating in your leiningen file

just tell your dev ring handler to load the shadow-cljs artifacts and that's it

:resource-paths [“resources”] the resource-paths in project can not be removed

resource path is another example of a classpath, just add it into :paths in deps.edn

i’ve added, but it seems doesn’t affect

and I'd refactor your project.clj file, I think the source of this mess is there, for example all the dependencies you have under your profiles, you don't need it with deps.edn, and figwhell cand shadow are solving the same problem in development so you don't want any cljsbuild or leiningen running

you can ofc have deps.edn aliasaes

what resource doesn't work for you?

wait a minute

i’ve tried again, works ok now

there is another problem, that is the compiled app.js init doesn’t executed

:modules {:app {:entries [admin.core]}} :devtools {:after-load admin.core/mount-components}}}}

this is setting in my shadow-cljs

it seems that mount-components doesn’t execute

(r/render [#'page] (.getElementById js/document "app"))

this is mount-components

ah it's fine, though denoting page as a variable is unusual

I see @haiyuan.vinurs you have :devtools in the wrong map

{:app {:devtools not {:app {} :devtools {}}

sorry Im blind, it is like that, I'm leaving anyway, maybe @thheller can see why it fails 😄

ah

😆

alternative is to just execute the function in that file (mount-components) at the bottom

ok, i try it first

well you've been busy 😛

@haiyuan.vinurs did you figure it out or still need help?

yes, need help

https://github.com/vinurs/admin

all code has been pushed

alright: first issue is the source-paths

when i visit the homepage, it seems doesn’t execute the mount-components function

you can either use shadow-cljs.edn to manage them, or deps.edn or project.clj

if you set either :deps or :lein in shadow-cljs.edn the :source-paths and :dependencies there will have no effect at all

and what do you actually want to use? the repo has everything so I'm not sure what you actually want

deps.edn or project.clj?

deps.edn

alright then you probably want to remove :source-paths from project.clj as well

yes

I'm not sure how lein-tools-deps works though but you are currently setting :source-paths in 3 places which is just confusing

there should be only one place where all of this is configured

so all set in the deps.edn?

yes probably the best

this is project.clj, lein may use different source paths in different env, how can i do this?

I don't know. check lein-tools-deps docs.

ok, i do this later, there is another problem

:dev
        {:compiler-options {:closure-warnings {:global-this :off}
                            :source-map true
                            :optimizations :none
                            :pretty-print true}}
        :release
        {:compiler-options {:optimizations :advanced
                            :pretty-print false
                            :closure-warnings
                            {:externs-validation :off
                             :non-standard-jsdoc :off}}}

this makes no sense

you can leave it in but you are just setting the already used defaults again

ok, i removed it

:compiler-options {:closure-warnings
                   {:global-this :off
                    :externs-validation :off
                    :non-standard-jsdoc :off}}

is probably what you want

is there any error with this?

looks fine

{:deps {:aliases [:cljs]}
 :builds
 {:app {:target :browser
        :output-dir "resources/public/js"
        :asset-path "/js"
        :compiler-options {:closure-warnings
                           {:global-this :off
                            :externs-validation :off
                            :non-standard-jsdoc :off}}
        :modules {:app {:entries [admin.core]}}
        :devtools {:after-load admin.core/mount-components}}}}

AFAICT that should be the config you need

what is the problem?

i changed the shadow-cljs.edn

it also doesn’t effect the app.js

what does that mean?

resources/public/js/app.js is the file shadow-cljs will create

you should be loading it at /js/app.js

yes, app.js has been created,

I can't find where the HTML is created that loads the file

but what is the issue?

the content is just the html content, but in html i wrote {% script “/js/app.js” %}, and when i visit this page, i want the html execute the mount-components function, it a render

admin/resources/html

home.html

ah. you expect :devtools {:after-load admin.core/mount-components} to call mount-components?

yes

that is not what that does. that tells the devtools to call that function after it has loaded code

it has nothing to do with your normal app flow

so you want :modules {:app {:init-fn admin.core/mount-components}}

that will make it run the function on initial load

oh no

you actually want the init! fn

so :modules {:app {:init-fn admin.core/init!}}

{:deps {:aliases [:cljs]}
 :builds
 {:app {:target :browser
        :output-dir "resources/public/js"
        :asset-path "/js"
        :compiler-options {:closure-warnings
                           {:global-this :off
                            :externs-validation :off
                            :non-standard-jsdoc :off}}
        :modules {:app {:init-fn admin.core/init!}}}}}


;; admin.core js

(defn ^:dev/after-load mount-components []
  (rf/clear-subscription-cache!)
  (r/render [#'page] (.getElementById js/document "app")))

ah haha

thanks

that is what I'd do probably

works now

^:dev/after-load tells the devtools to call that function after loading code. I think its cleaner there than in the build config

works the same though

the luminus template has to be the most complicated template ever 😛

there has to be an easier way to do this

yes, the author said would change to shadow-cljs next month

😆

if i change the mount-components to this, then i need to set :modules {:app {:init-fn admin.core/init!}} this?

yes it is meant that way by looking at the code

mount-components only re-renders code

init! actually does all the app initialization stuff

what options can I pass to shadow/release to get e.g. readable names?

thanks very much @thheller

seems like (shadow/release :thing {:debug true}) works 😄

@lilactown --pseudo-names would be :pseudo-names true

:debug is pseudo-names + source-maps

random question: is there a way to get chrome to tell me what JS corresponds to a line in a source map file?

ah. I might just disable or elide source-maps

thats why those are separate options 😉

well it’s being helpful in that I know what part of my CLJS code is slow. but I want to see the JS now 😛

any tricks you know of?

seems like if it can go JS line -> source map, i should be able to go the other way!

JS code after optimizations or before? 😛

after optimizations I guess

I just use pseudo names for that. the names are close enough so you can figure out where it came from in the CLJS code

can't jump directly from CLJS loc -> JS loc since the code may be changed in ways that make that impossible 😛

@lilactown there might be tools similar to this buried in the closure compiler stuff that allow going that way? https://clojureverse.org/t/server-side-decoding-of-javascript-sourcemaps/1591/3?u=thheller

when i do lein uberjar, it output these

@thheller

is it need to set somthing?

no. safe to ignore those ...

{:type :shadow.build.closure/invalid-closure-warning, :key :non-standard-jsdoc, :level :off, :shadow.build.log/level :warn} this means you can remove :non-standard-jsdoc from the build config

since it doesn't seem to exist

ok, it seems that it doesn’t need to move deps from project.clj to deps.edn, shadow-cljs can read deps from project.clj well

yeah just project.clj is fine. thought you wanted to use deps.edn

shadow-cljs doesn't read deps from project.clj in any way however. it just uses lein to launch itself.

so whatever is configured there applies

😆，i don’t know that shadow-cljs can read the deps from project.clj before

just now i tried it and works ok

if you have :lein true in your config shadow-cljs watch app literally runs lein run -m shadow.cljs.devtools.cli watch app

oh, i see

project.clj is never parsed in any way

or i just run shadow-cljs watch app the same effect?

shadow-cljs watch app

yes thats what I mean. you run shadow-cljs watch app and that internally just calls lein run -m shadow.cljs.devtools.cli watch app for you

you don't ever need to call lein yourself. its just what is done internally.

i see, thanks

I was looking at https://github.com/thheller/netlify-cljs and wondering if the same setup would work for a project using deps.edn instead of Lein.

@kenny the project doesn't actually use lein. netlify just enables maven caching if it finds the project.clj

no clue if it does the same for deps.edn?

I tried it and got:

Executable 'clojure' not found on system path.

https://github.com/netlify/build-image/blob/xenial/run-build-functions.sh#L394-L412

doesn't look like it supports deps.edn yet

lein isn't used to do anything other than caching deps

Gotcha. I was able to get it to work with the following:

curl -O 
chmod +x linux-install-1.10.0.442.sh

install_dir=/opt/buildhome/clojure
mkdir -p ${install_dir}
./linux-install-1.10.0.442.sh --prefix ${install_dir}

echo "Installing Clojure to ${install_dir}/bin"
export PATH="${install_dir}/bin":$PATH

that still won't cache the maven deps though

Right but at least it'll build. Unfortunate about caching though.

shadow-cljs unfortunately has too many deps so builds got way too slow for my taste without cache 😛

Yeah... Right now I am using manual deploys to Netlify on CircleCI but I'd really like to take advantage of the deploy and branch previews.

maybe they'd be open to adding support for deps.edn and maybe shadow-cljs.edn even

since I'm not actually using the platform I didn't bother asking

Netlify builds my shadow project just fine