@hlolli https://dev.clojure.org/jira/browse/CLJS-2395

closure v20180319 is now available on maven. will bump shadow-cljs later.

@thheller sleepelss night for me, I tried the new closure. Was hopeing it would fix a Quill bug I had completly randomly, evening before launching a new webapp. So two post-compilation bugs I'm gettiing. But as these are both admin endpoints, then I'm actually running shadow-cljs watch in production. Somehow build with optimizatioon :none gave me an error, wait I can send it...

shadow-cljs release :admin  ~/Documents/visitor
shadow-cljs - config: /home/hlolli/Documents/visitor/shadow-cljs.edn version: 2.2.20
shadow-cljs - connected to server
[:admin] Compiling ...
optimizations set to :none, can't optimize
{}
ExceptionInfo: optimizations set to :none, can't optimize
	clojure.core/ex-info (core.clj:4739)
	clojure.core/ex-info (core.clj:4739)
	shadow.build.closure/optimize (closure.clj:1081)
	shadow.build.closure/optimize (closure.clj:1074)
	shadow.build.api/optimize (api.clj:182)
	shadow.build.api/optimize (api.clj:176)
	shadow.build/optimize (build.clj:318)
	shadow.build/optimize (build.clj:310)

yeah :none is not an optmization setting .. its literally just compile

nice, I guess that omits the devtools?

yes

but that doesn't affect the optimizations used for JS at all

you can set :js-options {:optimizations :whitespace} to switch it from :simple

but can you say more about the quill thing? does it still not work with the latest closure?

nope, I'll send the code which fails, it's react-quill actually

(:require ["react-quill" :as Quill])

(defn component []
  (let [quill-ref (atom nil)]
    (r/create-class
     {:reagent-render
      (fn [] [:> Quill {:default-value ""
                        :ref (fn [el] (reset! quill-ref el))
                        :modules {:toolbar {:container [[{:header [1 2 3 4 5 false]}]
                                                        ["bold" "italic" "underline" "strike" "blockquote"]
                                                        [{:list "ordered"} {:list "bullet"} {:indent "-1"} {:indent "+1"}]
                                                        ["link" "image"]
                                                        ["clean"]]
                                            :handlers  {:image (fn [_] 
                                                                 (let [editor (.getEditor @quill-ref)
                                                                       selection (.getSelection editor)]
                                                                   (.insertEmbed editor
                                                                                 selection.index "image"
                                                                                 (js/window.prompt "Please provide an image url")
                                                                                 "user")))}}}}])})))

admin.cljs:429 Uncaught TypeError: b.fi is not a function
    at b.<anonymous> (admin.cljs:429)
    at HTMLButtonElement.<anonymous> (quill.js:9393)
(anonymous) @ admin.cljs:429
(anonymous) @ quill.js:9393

so line 423 in admin.cljs is .inserEmbed editor

com.google.javascript/closure-compiler-unshaded "v20180319" the closure version

is that error with watch? or release only?

release only

did you try shadow-cljs release the-build --debug?

should give a better clue what b.fi is.

do you have :infer-externs :auto?

I'm running now --debug, didn't touch the :infer-extern option

just trying to rule out that it is not a problem on the CLJS side.

definitely always turn on :compiler-options {:infer-externs :auto} if you run into any issues

ok I try that, --debug only gave me warnings about transit and nashorn

runtime error should be better though

boom, it spotted something shade there now

431 |                                                                     (.insertEmbed editor
---------------------------------------------------------------------------^----
 Cannot infer target type in expression (. editor insertEmbed selection.index "image" (js/window.prompt "Hvað er URL á myndina?") "user")

I think all you'll need is ^js editor (.getEditor @quill-ref)

yeah exactly

you need to tell the compiler that editor is a JS object and nothing that uses it should be renamed

better later than never, to learn

https://shadow-cljs.github.io/docs/UsersGuide.html#infer-externs

https://code.thheller.com/blog/shadow-cljs/2017/10/15/externs-the-bane-of-every-release-build.html

so carrot js is a shadow reader?

never seen this before

you mean ^js?

yes, well it fixed it! wow, easy

^js is a standard CLJS thing for tagging a thing with a type

ususally in clojure this would be a class typehint like ^String

ah yes, I've seen that

but in CLJS we don't need classes so we only need to infer that the thing is a JS object or a CLJS object

CLJS is fine to rename, JS will generated externs so it won't be renamed

but you'll only get the warnings if :infer-externs :auto is on

can't turn that on by default since it may generate too many warnings

ah I see, now earlier talks here on that make more sense to me

Has anyone used shadow with devcards?

If so, any special caveats?

@jmckitrick we use shadow with devcards

we have a file like this:

(ns atlas-crm.cards
  (:require
  .... namespaces with cards
   [devcards.core :as dc :refer-macros [start-devcard-ui!]]))

(start-devcard-ui!)

(defn refresh []) ;; Used for devcards live reload support

:devcards {:target :browser
                     :asset-path "/js/devcards"
                     :output-dir "resources/public/js/devcards/"
                     :compiler-options {:devcards true :external-config {:fulcro.inspect/config {:launch-keystroke "ctrl-space"}}}
                     :modules {:devcards {:entries [atlas-crm.cards]}}
                     :devtools {:after-load atlas-crm.cards/refresh
                                :http-port 8600
                                :http-root "public" ;; We don't use this but our handler, but this makes shadow start a http server
                                :http-handler dev.test-handler/handler
                                :preloads [fulcro.inspect.preload]}}

Does anyone here know the command to get the page in shadow-cljs which shows how much space each dep or ns takes

@mitchelkuijpers (shadow.cljs.devtools.api/release-snapshot :the-build {}) then

Awesome thnx!

hmm, does this look like correct usage of rename-prefixing for closure? :compiler-options {:rename-prefix-namespace "App"}

i’m running into some collisions with other code on a page, using :advanced compilation, and it doesn’t seem to have an effect

@mhuebert this is not currently support because it needs special considerations for :modules

if you just want to isolate your code add

:modules {:main {:entries ... :prepend "(function(){" :append "})();"}}

also problematic if you use more than one module though

does that have any effect on exports?

no

hmm. i do have two modules

yeah thats a problem

I have a plan for this but didn't get to it yet

what exactly is the issue for you? would externs maybe solve it?

it overwrites

which an existing app uses for something

then add externs for that, so closure won't use that name

<project-root>/externs/your-build.txt global:io should do it

ah that was that special externs file lookup/format?

yes

simple

is :stable-names supported?

has been the default in shadow-cljs for a couple of years. it is always on yes.

🙂

@thheller @lee.justin.m I was getting the same results even after I used NS requires. But after looking at the compiled output, I found a workaround. Closure was optimizing away the (.bind stmt) call, probably because it was in a let with no binding of its results (even though it returns nil). When I bound the result Closure let it through:

(let [db ^js (:db @state)
      stmt (.prepare db "SELECT * ...")
      bound? (.bind stmt ids)])

(let [
db ^Database (Database. dbBuffer)  
stmt ^Statement (db/prepare sqlStr)
bound? (stmt/bind ids)])

@thosmos is sql.js your file or is it on npm?

it's from NPM

why not import it as an npm module?

i think weird shit happens when you import as javascript

Is that not what I'm doing here: (:require ["sql.js" :as sql :refer [Database Statement])

no you’re including the actual file

what you want to do is refer to the npm package name and then install the package in your repository using yarn or npm

https://www.npmjs.com/package/sql.js its the package name. so everything is correct

Yes it's in package.json as a dependency and I use yarn to download it

what exactly was the problem again?

(ns my.app (:require ["sql.js" :as sql :refer [Database Statement])) that should work just fine?

@thheller turns out one of the function calls was getting optimized away by Closure

@thheller doesn’t that run it through the optimizer?

I thought javascript includes were optimized whereas npm includes just go through “simple”

one of my function calls, not the package's function calls

(let [db ^js (:db @state)
      stmt (.prepare db "SELECT * ...")
      _ (.bind stmt ids)]) ;; this call got elided

@lee.justin.m I don't understand. what are you talking about? sql.js is a normal npm package so it gets treated like any other. so it goes through :simple. but simple can also remove code.

@thosmos how did you confirm that this call specifically gets elided?

sorry i guess i got confused. i though that if you include a raw js file then it was treated differently. please ignore me.

Oh, but this is in an electron app in the UI process which is being built with :target :browser

@lee.justin.m raw .js file requires *always* start with either / or ./. anything that does not start with those is a npm package.

It works when I use :js-options {:js-provider :require} but not :shadow

oh. got it.

@thosmos then use that. should be fine.

@thheller I confirmed by looking at the compiled JS that's output

:shadow only rewrites the whole npm stuff because the browser doesn't have access to require. electron does so its totally fine to do this.

but that would not explain why the .bind does not get removed with :require

because that doesn't affect the generated code at all

it is pretty much identical as far as closure in concerned

@thheller thanks for shadow-cljs. It's great! I love the server mode!