0.2.8 Reitit For some reason Swagger generation fails in situation when response body is vector containing data-spec. Generating data spec with ds/spec works fine so syntax should be legal. Is this bug or a feature?

@heikki.hamalainen it seems that the reitit.coercion.spec/IntoSpec is missing a mapping for vectors/sequences. PR welcome.

Great 🙂 maybe I can make this.

@ikitommi PR ready for inspection https://github.com/metosin/reitit/pull/182

In the [initial blog post](https://www.metosin.fi/blog/reitit/) you mentioned a re-frame helper module. Where can I find this?

@urzds re-frame helpers haven't been published, but the controllers are part of reitit-frontend, here's a sample app (with reagent): https://github.com/metosin/reitit/blob/master/examples/frontend-controllers/src/frontend/core.cljs

@ikitommi :start and :stop are functions that will be called when browsing to a route / page and when leaving it again?

yes, the docs are kinda missing, but all the source code for controllers is in here: https://github.com/metosin/reitit/blob/master/modules/reitit-frontend/src/reitit/frontend/controllers.cljs

So that's where I would put the re-frame/dispatch in order to trigger the re-frame dominoes to switch the page?

there is also kee-frame, which uses reitit, but with it’s own global controller definitions.

@juhoteperi could explain it better, but the router takes care of page changes, controllers are for preparing data for the page, e.g.

[["/users" {:controllers [load-users]}
  ["/:id" {:controllers [load-user-by-id]}]]
 ["/pastas" {:controllers [load-pastas]}]]

frontend routing is naturally stateful, and controllers are a good fit there.

I think the re-frame helpers could be put into an example, not much code there either.

The callback to router start! should be used to call dispatch to change page

There is no reason to write any re-frame helpers

@juhoteperi Could you please explain that some more? Which callback? And dispatch means re-frame/dispatch and "change page" means whatever mechanism my application uses to change the page? (e.g. :active-page in the :db?)

https://github.com/metosin/reitit/blob/master/examples/frontend/src/frontend/core.cljs#L72

@heikki.hamalainen the vector data-spec fix out in [metosin/reitit "0.2.9"], thanks!

There seems to be also in :response handling same kind of presupposition that response is always map -> doesnt allow for example {200 [int?] It seems that in this situation the problem lies in https://github.com/metosin/reitit/blob/master/modules/reitit-spec/src/reitit/coercion/spec.cljc create function which I try to fix this next 🙂

@heikki.hamalainen isn't that {200 {:body [int?]}}

@ikitommi Uups, stupid me. - i didnt have that body key there Forget everything 🙂 Workds fine. Too late - have to go to home.