Fork me on GitHub
#pedestal
<
2017-11-20
>
nblumoe09:11:13

Hey, the Jetty websocket implementation passes the message payload as the only argument to the :on-text handler. This means that identifying the client which sent this message depends on the payload: https://github.com/pedestal/pedestal/blob/e9230c3a49b7036b195267c7c24b0c4881c941b5/jetty/src/io/pedestal/http/jetty/websockets.clj#L74 Instead this could also be done by passing the Session to the handler, too. Is there a good reason why this wasn’t done in the implementation? Would you be open for a PR adding this?

ddeaguiar14:11:48

@nblumoe I think the best place for this question is the Pedestal User email group. Paul DeGrandis would be the best person to answer it.

nblumoe14:11:38

Great, thanks. Will give it a try there.