This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-11-20
Channels
- # beginners (17)
- # boot (19)
- # chestnut (1)
- # cider (25)
- # clara (1)
- # cljs-dev (15)
- # cljsrn (10)
- # clojars (9)
- # clojure (182)
- # clojure-brasil (27)
- # clojure-dusseldorf (2)
- # clojure-gamedev (5)
- # clojure-germany (1)
- # clojure-greece (2)
- # clojure-italy (18)
- # clojure-poland (5)
- # clojure-romania (3)
- # clojure-russia (29)
- # clojure-serbia (6)
- # clojure-spec (9)
- # clojure-uk (77)
- # clojure-ukraine (1)
- # clojurescript (61)
- # cursive (5)
- # datomic (20)
- # defnpodcast (1)
- # emacs (10)
- # fulcro (2)
- # graphql (2)
- # hoplon (11)
- # lumo (4)
- # off-topic (50)
- # om (3)
- # onyx (26)
- # other-languages (39)
- # parinfer (2)
- # pedestal (5)
- # re-frame (32)
- # reagent (48)
- # rum (7)
- # shadow-cljs (10)
- # spacemacs (29)
- # sql (10)
- # unrepl (58)
- # vim (3)
Hey, the Jetty websocket implementation passes the message payload as the only argument to the :on-text
handler. This means that identifying the client which sent this message depends on the payload: https://github.com/pedestal/pedestal/blob/e9230c3a49b7036b195267c7c24b0c4881c941b5/jetty/src/io/pedestal/http/jetty/websockets.clj#L74 Instead this could also be done by passing the Session
to the handler, too. Is there a good reason why this wasn’t done in the implementation? Would you be open for a PR adding this?
@nblumoe I think the best place for this question is the Pedestal User email group. Paul DeGrandis would be the best person to answer it.
It actually got already covered (kind of) here: https://groups.google.com/forum/#!searchin/pedestal-users/websocket%7Csort:date/pedestal-users/IOc-WKkTFLM/QmMe1iBBAQAJ
@mtnygard Left a note at this commit: https://github.com/pedestal/pedestal/commit/0f242071c7af09c344cc98bfcb688b42b16231e1