Clojurians Log v2
Clojure programming
Channels
Apps
parinfer 2017-08-31
cfleming 2017-08-31T03:14:28.000107Z
@shaunlebron I’m looking at #173 - I made two fixes which made that case work, but only at the expense of breaking other test cases around indent/dedent 😞
cfleming 2017-08-31T03:16:36.000133Z
Actually, only one of my fixes is specific to this problem, the other I think should be made anyway, all tests pass with it.
cfleming 2017-08-31T03:48:12.000002Z
Ok, I have a fix that passes all current unit tests, and also fixes #173.
cfleming 2017-08-31T03:48:46.000054Z
But I’m really not sure it’s the right solution, or at least I’m not 100% sure I actually understand the problem.
cfleming 2017-08-31T04:00:04.000106Z
Unfortunately the markdown test parser can’t handle this case - it requires diff lines to have all the changes adjacent. My JS regexp-fu is probably not up to fixing that.
cfleming 2017-08-31T04:00:32.000143Z
i.e. it only allows one change per line.
cfleming 2017-08-31T04:15:10.000003Z
Ok, PR sent for discussion: https://github.com/shaunlebron/parinfer/pull/174
shaunlebron 2017-08-31T06:07:58.000005Z
@cfleming: thanks 🎉
shaunlebron 2017-08-31T06:08:55.000100Z
will merge this soon, i want to do some manual testing tomorrow and fix the diff annotation parser to allow multiple changes on a line for this
shaunlebron 2017-08-31T06:10:13.000123Z
btw, i’ve been working this week on https://github.com/shaunlebron/parinfer/issues/92
shaunlebron 2017-08-31T06:10:46.000042Z
i’ve had to rethink a lot of stuff, but it’s looking good so far
cfleming 2017-08-31T07:36:27.000280Z
Oh nice, that will be a good change.