This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-08-31
Channels
- # aleph (38)
- # beginners (91)
- # boot (4)
- # cider (20)
- # clara (11)
- # cljs-dev (4)
- # clojure (179)
- # clojure-greece (1)
- # clojure-italy (16)
- # clojure-portugal (1)
- # clojure-russia (1)
- # clojure-sanfrancisco (1)
- # clojure-spec (183)
- # clojure-uk (50)
- # clojurescript (111)
- # core-async (24)
- # cursive (4)
- # datascript (11)
- # datomic (29)
- # fulcro (120)
- # gorilla (2)
- # jobs (1)
- # keechma (2)
- # keyboards (26)
- # leiningen (4)
- # luminus (7)
- # lumo (15)
- # off-topic (2)
- # onyx (31)
- # parinfer (12)
- # portkey (1)
- # protorepl (1)
- # re-frame (50)
- # reagent (106)
- # remote-jobs (1)
- # ring-swagger (2)
- # rum (10)
- # spacemacs (17)
- # sql (16)
- # test-check (1)
- # yada (2)
@shaunlebron I’m looking at #173 - I made two fixes which made that case work, but only at the expense of breaking other test cases around indent/dedent 😞
Actually, only one of my fixes is specific to this problem, the other I think should be made anyway, all tests pass with it.
But I’m really not sure it’s the right solution, or at least I’m not 100% sure I actually understand the problem.
Unfortunately the markdown test parser can’t handle this case - it requires diff lines to have all the changes adjacent. My JS regexp-fu is probably not up to fixing that.
Ok, PR sent for discussion: https://github.com/shaunlebron/parinfer/pull/174
@cfleming: thanks 🎉
will merge this soon, i want to do some manual testing tomorrow and fix the diff annotation parser to allow multiple changes on a line for this
btw, i’ve been working this week on https://github.com/shaunlebron/parinfer/issues/92
i’ve had to rethink a lot of stuff, but it’s looking good so far