Fork me on GitHub
#parinfer
<
2017-08-31
>
cfleming03:08:28

@shaunlebron I’m looking at #173 - I made two fixes which made that case work, but only at the expense of breaking other test cases around indent/dedent 😞

cfleming03:08:36

Actually, only one of my fixes is specific to this problem, the other I think should be made anyway, all tests pass with it.

cfleming03:08:12

Ok, I have a fix that passes all current unit tests, and also fixes #173.

cfleming03:08:46

But I’m really not sure it’s the right solution, or at least I’m not 100% sure I actually understand the problem.

cfleming04:08:04

Unfortunately the markdown test parser can’t handle this case - it requires diff lines to have all the changes adjacent. My JS regexp-fu is probably not up to fixing that.

cfleming04:08:32

i.e. it only allows one change per line.

shaunlebron06:08:55

will merge this soon, i want to do some manual testing tomorrow and fix the diff annotation parser to allow multiple changes on a line for this

shaunlebron06:08:46

i’ve had to rethink a lot of stuff, but it’s looking good so far

cfleming07:08:27

Oh nice, that will be a good change.