Maybe thread this discussion?

i'm using https://github.com/metosin/ring-swagger maybe this doesn't work anymore? (it's pretty old). i looked at some of the tests and my swagger objects look pretty similar to the ones in the tests. i get complaints from swagger-jsonfn saying it doesn't know how to convert my object into a swagger schema

looking at swagger's docs https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#parameterObject i think malli.swagger is generating wrong data

Currently it produces OpenAPI 2.x https://github.com/metosin/malli#swagger2

well, malli.swagger output is throwing errors for the other library for swagger that metosin made. i don't know what to do

{
  "skipParam": {
    "name": "skip",
    "in": "query",
    "description": "number of items to skip",
    "required": true,
    "type": "integer",
    "format": "int32"
  },
  "limitParam": {
    "name": "limit",
    "in": "query",
    "description": "max records to return",
    "required": true,
    "type": "integer",
    "format": "int32"
  }
}

i guess i have to study the swagger docs and make my own transformer

Please file an issue and we will look into it. 🙂

I'm not sure if Tommi has intended that malli.swagger should play along with ring-swagger

😞

I don't also understand why would both be needed. AFAIK they both generate swagger.json

That you can use to render swagger ui

Difference being that ring-swagger can generate the json from plumatic schema / clojure.spec and malli.swagger does that for malli schemas

Uhhhmm.. Need to correct myself. Looks like malli.swagger produces "chunks" of swagger 2.0 compatible JSON, not the complete swagger doc.

ok, i did not know that

it makes sense that malli swagger wouldn't produce the whole swagger doc, i just don't know what to do with it's output

Which kinda makes sense since Malli knows only about the shape of data. It doesn't know anything about route definitions and other stuff that goes into swagger spec

Are you using reitit by any chance?

yada

Because there's reitit.swagger

i was hacking on yada swagger to try to get it working with malli

changing over to reitit is a bigger challenge

Yeah, I see. I don't know how Yada swagger works but in reitit it works so that it constructs the full swagger.json from route data + schema definitions. For schemas it supports plumatic, clojure.spec and malli.. And when it's constructing the swagger, it checks which impl it is, generates the needed JSON chunks and places them into the swagger doc

yeah, i used malli swagger to generate the params data, but it still wasn't enough

Yeah.. I'm trying to look if ring-swagger has extension points where you could jack in malli

Mhmhmh to my 👀 it looks like some serious hacking would be required

i think i just have to change the params code, i already have merged route + method params

i just don't know what to change the params to, seems like i need to build ref structures and flatten out nested maps or something

i poked at it for a few hours, and i think i rather just see about using reitit...

here too https://github.com/metosin/reitit/tree/master/examples/ring-malli-swagger

thanks, I think that's exactly what I need to figure out how to fix yada

Swagger is specifically pre-OpenAPI, which does get confusing. The name change and a whole bunch of backwards breaking changes happened with the release of OpenAPI 3.0, so a good mental note is that you really shouldn’t expect one from another. This isn’t necessarily very helpful to the issue at hand, but still an unfortunate detail one should be aware of.