Fork me on GitHub
#lumo
<
2018-10-20
>
onetom12:10:02

Thanks for the PR review, @anmonteiro I will try to incorporate your recommendations tonight.

onetom12:10:13

I saw you tried to unbreak the windows build and incremented the nodejs version along the way. As I understand the 9.x line has been dropped since the 10.x became the current main version line (about 10 days ago): https://github.com/nodejs/Release#release-schedule Would it worth upgrading to 10.x? Is there any strong counter-argument for doing so? Would it be more likely that it builds on Windows too?

anmonteiro13:10:15

@onetom upgrading to Node v10 is gonna take a little time

anmonteiro13:10:23

time that I don’t have to put into it

anmonteiro13:10:34

specifically they changed the handling of command line arguments

anmonteiro13:10:00

so it needs to be patched properly in nexe

anmonteiro13:10:55

another useful task would be to get the CI running on Windows again

onetom14:10:02

i haven't touched windows in decades, so i can't help much with that im afraid

anmonteiro13:10:02

it just runs out of memory

anmonteiro13:10:12

maybe trying the newly added Travis support for Windows

onetom14:10:42

i only have have some ancient jenkins experience (when it was still called hudson 🙂 i've touched on gitlab ci recently though. for example i've documented how to setup a gitlab runner on aws using nixos: https://gitlab.com/oax/dex-poc#ci-runner i think that was a pretty cool solution, because we have great control over the CI environment with extra minimal effort.

vigilancetech22:10:51

I'm trying to get spiral to connect to a lumo socket-repl. I fire up the lumo at port 5555, go into a cljs source file under the same project hierarchy and do spiral-connect-to and give it localhost:5555 and it says "unrepl says hi!" and "waiting on UNREPL.... then hangs. I look into the spiral-client[localhost:5555] buffer and it says:

".replaceAll is not a function
     (evalmachine.<anonymous>:2:37929)
     (evalmachine.<anonymous>:29:4)
     Script.runInThisContext (vm.cljs:65:33)
     Object.runInThisContext (vm.cljs:197:38)
     ()
     (Object.lumo.repl.caching_node_eval)
     (NO_SOURCE_FILE <embedded>:5824:287)
     z (NO_SOURCE_FILE <embedded>:5825:306)
     (NO_SOURCE_FILE <embedded>:5820:508)
     Function.cljs.core.trampoline.cljs$core$IFn$_invoke$arity$1 (NO_SOURCE_FILE <embedded>:1916:142)

cljs.user=>
According to what I can find on the net, its cuz its trying to use an unsupported (in cljs) global string replace function. Is this supposed to be working at all or still a WIP?