Don't we suggest a code action to require that?

require?

Yeah, it require the alias and change that place to use the alias

but the require was already there

This is for :aliased-namespace-symbol https://github.com/clj-kondo/clj-kondo/blob/master/doc/linters.md#aliased-namespace-symbol

Hum, I see, is this linter new? Also what are the code actions available on that line?

yes, it's new and optional (off by default)

I see, that could be a code action or part of clean-ns, not sure if would be good touch the rest of the code on clean-ns, but a code action to fix that line is convenient indeed

Do you intend to in the future change the level to something else than off ?

no

I will only enable linters that can detect serious problems or where the compiler may also warn, from now on

Feel free to create a issue about a code action to fix it

Cool right? :)

Very :)

Love this action

I use this often in RCFs ❤️

@UJY23QLS1 Also check out :config-in-comment in which you can tweak linters for RFCs

https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#override-config-in-comment-forms

That's super cool! Along with the other :config-in-* keys. While my usages of the above action isn't as global, I'm very happy to learn about those.

Other code actions are available?

What's the server version?

I'm on

clojure-lsp 2022.06.22-14.09.50
clj-kondo 2022.06.22

maybe it's something with the project I'm working on - let me try a couple more

Also I suggest update your server to latest

oh yeah, for sure

so odd - it works in other projects but not in the one I've been working on so far, I'll dig into it

Maybe a exception from server

Check server logs

I think I found it - the require option doesn't show up until I open the file with that namespace in other buffer, until then Emacs is not aware if that namespace exists so it only suggests creating it

must be the classpath configuration for that project that breaks namespace lookups

(I think)

Certainly is the classpath issue

It's weird because at least lsp-mode handles and shows a message that server sent when the classpath fails

In a recent server version at least

yeah, I'll upgrade first and see if that resolves the issue

I doubt it will solve, but will say what command didn't return a classpath

ah neat, that will def help!

Same thing after upgrading - I have to open a buffer in emacs for the 'add require' option to show up and work, very weird.

And what about the server logs? Any mention to classpath ?

any tips how to see them? eglot's log buffers just show json-rpc responses

https://clojure-lsp.io/troubleshooting/#server-log

thank you 🙏

hm, nothing suspicious in clojure-lsp logs - as in no errors etc

Any mention to classpath? It should mention the found classpath

Nothing so far, I'll resume tomorrow and test with other projects

Ok, found the reason - Eglot uses project.el under wraps, and that sometimes fails to detect correct project root (I work in a mono repo)

no, but some people in this channel have

It feels faster than clojure-lsp for sure, sometimes things don't work exactly the same but it might be due to how some of my projects are setup

clojure-lsp is the server which is the same, so probably you meant lsp-mode

ah yes, sorry - I'm debugging all 3 right now hence the confusion

Clojure-lsp has a extract to def code action, isn't that enough already?

It's serviceable for one-offs, but quite tedious in big lets. But that was actually just an example for the broader question: is clojure-lsp the place to add that type of functionality?

I see, so for common refactors we could code a code action for that, but if your question is: Can I code my own refactorings, the answer ATM is no

Why not actually? Perhaps a similar thing as clj-kondo hooks could be made

But of course, one could also do their own thing with a babashka script and rewrite-clj

Yeah, would be a nice feature, but seems complex similar to hooks

A vim macro would probably be a much simpler solution in this case anyway

Also looking to use/create something to load a stacktrace's locations into the vim location list

I cretaed this issue to discuss and think more about this possible feature: https://github.com/clojure-lsp/clojure-lsp/issues/1333