Fork me on GitHub
#lsp
<
2021-07-03
>
vemv14:07:27

As perhaps a documentation topic, https://github.com/clojure-lsp/clojure-lsp/ or its links don't immediately say whether cljs is supported

ericdallo14:07:26

Good point, I think most of features work with cljs (maybe clean-ns not that much)

ericdallo14:07:49

But agree it's a good idea add a comment about that somewhere

👍 2
vemv14:07:16

> (maybe clean-ns not that much) oh interesting, I figured both targets would be on par (since a static approach is followed, so JVM clj doesn't enjoy any 'privilege'?)

ericdallo14:07:12

yeah, I don't code clojurescript usually, so it'd need to test but I think those cljs requires that require js directly could not work fine with clean-ns

ericdallo14:07:22

otherwise, I think everything else works

👍 2
vemv15:07:22

cljs is an interesting topic, could be easily a killer/distinctive feature for the project (I'd happily contribute but always have quite a lot on my OSS plate :/)

vemv15:07:00

I mean if cljs was tested/CI'd it would feel a little more dependable for that use case

ericdallo15:07:03

No problem, if you could provide an issue that'd be a great start 🙂 Then I can work on that when have the time

ericdallo15:07:42

yes agree, there are tests for cljs/cljc files already, if you find anything else that cljs is quite different we can add more tests/fix it

🙌 2
borkdude15:07:08

as for clj-kondo: cljs is an explicit goal, if something isn't working correctly there I consider it as a bug

borkdude15:07:23

so from an analysis data perspective, I think you should be good

👌 5