Fork me on GitHub
#helix
<
2021-09-05
>
az23:09:44

I’ve been playing with helix for the last few days and I’m wondering if I’m missing something when it comes to performance and prop passing. I’m seeing re-renders happening on a list even when using memoization. If I’m passing clojure maps and functions (wrapped in use-callback hook) via props, should I expect a render only if changed? For comparison, this same setup does optimize rendering if I run reagent. Also, I’ve noticed that if I have a recursive call to a defnc that uses wrap memo, inspecting react tools component tab only tags the first call to the defnc. If I fully qualify the call to the defnc it then adds the memo tag to the profiler. Some quick vids to help explain: https://www.loom.com/share/5813c34f828a45bd844dd492f51655a9 Issue with recursive call: https://www.loom.com/share/dbd6c7cf23e743af9fba837353eba3a9 Link to the repo: https://github.com/brancusi/test-helix

lilactown23:09:26

@aramz the videos + github repo is really great for understanding your question

lilactown23:09:56

I think there's at least one thing happening I'm sure of

lilactown23:09:26

the thing I'm not sure, is the lack of the "Memo" label in the dev tools. I'm worried that could be a bug

lilactown23:09:41

but I'm going to set that aside for now, because I think there's another issue that can be fixed in your code