I have been chasing concurrency gremlins in a project, and after trace logging I see resolvers returning values that never seem to get delivered to the promise returned from execute-parsed-query-async, I have a patched version of com.walmartlabs.lacinia.resolve/resolve-promise that seems to fix it, should I submit a pr? I don't have a small reproducible test case for it

https://github.com/walmartlabs/lacinia/compare/master...hiredman:master is the diff

Looks good, though if you look at the implementation of Promise, I'm surprised it makes a difference.

I am not sure what you mean by Promise? If you mean clojure.core/promise the issue is using two promises without coordination between them. if one thread runs on-deliver! up to line 156, then in the middle there another thread runs all of deliver! up to line 174, then both threads miss each other

Well, maybe we can do a short cycle to get that into an early 0.28.0 rc.

that would be super. I haven't figured out what I want to do until this fix is upstreamed, I've got plenty of other issues to deal with, and we have direct linking turned on for deployments, so money patching is tricky

Well, you could easily do a local fork with a variation of the artifact name.

I'll want to see if there's performance impact from this change but it probably needs to go in either way, for correctness.

But it's going to be terrible to test, like all concurrency issues.

Are there any known/common issues with lacinia and concurrency? & if so, is there documentation anywhere re dealing with it? When several requests are made in rapid succession, I end up with lacinia/execute throwing some pretty weird errors, eg

{:message "Exception applying arguments to field `chart_data': For argument `chart_params', for input string: \".2201071717E4.2201071717E4\"", :query-path [], :locations [{:line 1, :column 0}], :field :chart_data, :argument :chart_params, :value "2017-10-01", :type-name :Date}

what do you mean by interleaved?

Just that if you compare ".2201071717E4.2201071717E4" to "2017-10-01" it looks suspiciously like the former is being built from multiple, interleaved copies of the latter, along with some other bit of data. Could be totally wrong; I'm just hard-put to see where else that bizarre string could be coming from.

oh, you are likely using SimpleDateFormat to parse the date, and that class isn't thread safe

Ah, bingo, bet that's it. Thanks @hiredman, nice catch!

oh man, I've spent several hours debugging exactly that problem, probably three times in my career.

Yeah, I feel really lucky that someone just headed me off at the pass 😄

Those lacinia errors are still a bit opaque to me -- just out of being new to them -- so it probably would have taken me a painfully long time to realize that it was about the val being passed to the date parser.

(plus I didn't realize that SDF is non-thread-safe 😊 )

I see this in the docs -

By convention, the built-in scalar types are identified as symbols, such as {:type String}. Other types (objects, interfaces, enums, and unions) are identified as keywords, {:type (list :character)}. It actually makes no difference; internally everything is converted to keywords in the compiled schema.

no

that isn't valid edn

Hmm… gotcha. Presumably ignoring the typo {:type (list :Int)}… thanks…

{:type (list Int)} and {:type (list :Int)} are exactly the same, just a matter of personal preference.

Internally, the first is converted to the second.

Everything is a keyword in the compiled schema.

I see. So it is valid. Many thanks…

I’m trying to use a tool to generate schema docs from an introspection query and it’s giving me this error back:

does this look like something that should be supported?

or is the tool assuming a particular implementation of the server?

I'll have to research that; our directives support is not very good and it's quite likely we're missing something there.

man the javascript ecosystem is garbage

“use our simple static GraphQL doc generator” … “step 10, install webpack”

I'm an outsider looking in there, but it feels like a bit of chaos. Plus it's alien (how modules are downloaded, documented, etc.). JS devs who come to Clojure and Java are likely equally unimpressed.

I just tried another tool and got the same exact error

would you like me to file an issue?