Clojurians Log v2

@bhauman I see you’re trying to push Sablono to support React 16

but Devcards is still not fully React 16 compat

the next release is?

specifically devcards.system/cljs-logo uses React.DOM

https://github.com/bhauman/devcards/blob/master/src/devcards/system.cljs#L503-L508

and that was removed

you may want to use js/React.createElement

I just built a Devcards Snapshot from master

and it’s choking on that

Oh thanks!!

np

I’ll report anything else I find

I don't know how that made it this far

actually let me fix that locally to see if that makes it work

@bhauman https://github.com/bhauman/devcards/pull/129

this made it work for me

(also backwards compatible)

merged

thanks

@bhauman can you deploy a snapshot with sablono 0.8.1-SNAPSHOT?

sure!

thanks!

that’s working for me with React 16

even though @r0man didn’t release 0.8.1 yet, there’s the snapshot which works

it will be about 30 minutes before I cut a release

no rush

@bhauman ooops another PR incoming, I’m sloppy and found more cases of React.DOM

let me grep the whole project

make sure I don’t mess this one up

@bhauman OK this is the last one, makes Devcards work with React 16 + a rather comprehensive collection of devcards https://github.com/bhauman/devcards/pull/130

sorry for the churn

@anmonteiro deployed 0.2.4-SNAPSHOT

thanks!

Thanks for the help!