Fork me on GitHub
#devcards
<
2017-09-28
>
anmonteiro19:09:15

@bhauman I see you’re trying to push Sablono to support React 16

anmonteiro19:09:24

but Devcards is still not fully React 16 compat

bhauman19:09:37

the next release is?

anmonteiro19:09:40

specifically devcards.system/cljs-logo uses React.DOM

anmonteiro19:09:47

and that was removed

anmonteiro19:09:54

you may want to use js/React.createElement

anmonteiro20:09:12

I just built a Devcards Snapshot from master

anmonteiro20:09:14

and it’s choking on that

bhauman20:09:24

Oh thanks!!

anmonteiro20:09:34

I’ll report anything else I find

bhauman20:09:44

I don't know how that made it this far

anmonteiro20:09:15

actually let me fix that locally to see if that makes it work

anmonteiro20:09:08

this made it work for me

anmonteiro20:09:18

(also backwards compatible)

anmonteiro20:09:50

@bhauman can you deploy a snapshot with sablono 0.8.1-SNAPSHOT?

anmonteiro20:09:18

that’s working for me with React 16

anmonteiro20:09:36

even though @r0man didn’t release 0.8.1 yet, there’s the snapshot which works

bhauman20:09:19

it will be about 30 minutes before I cut a release

anmonteiro20:09:50

@bhauman ooops another PR incoming, I’m sloppy and found more cases of React.DOM

anmonteiro20:09:40

let me grep the whole project

anmonteiro20:09:46

make sure I don’t mess this one up

anmonteiro20:09:55

@bhauman OK this is the last one, makes Devcards work with React 16 + a rather comprehensive collection of devcards https://github.com/bhauman/devcards/pull/130

anmonteiro20:09:07

sorry for the churn

bhauman21:09:32

@anmonteiro deployed 0.2.4-SNAPSHOT

bhauman21:09:43

Thanks for the help!