This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-09-28
Channels
- # ai (1)
- # beginners (239)
- # bitcoin (1)
- # boot (4)
- # cider (5)
- # clara (3)
- # cljs-dev (16)
- # cljsjs (5)
- # cljsrn (1)
- # clojure (152)
- # clojure-android (3)
- # clojure-dev (3)
- # clojure-greece (4)
- # clojure-italy (5)
- # clojure-spec (14)
- # clojure-uk (24)
- # clojurescript (81)
- # data-science (1)
- # datomic (47)
- # devcards (34)
- # docs (3)
- # emacs (6)
- # ethereum (1)
- # events (9)
- # flambo (5)
- # fulcro (11)
- # graphql (1)
- # immutant (3)
- # lein-figwheel (2)
- # leiningen (2)
- # luminus (6)
- # lumo (90)
- # off-topic (25)
- # proton (2)
- # re-frame (44)
- # reagent (5)
- # ring (7)
- # ring-swagger (11)
- # shadow-cljs (11)
- # spacemacs (6)
- # vim (13)
- # yada (25)
@bhauman I see you’re trying to push Sablono to support React 16
but Devcards is still not fully React 16 compat
specifically devcards.system/cljs-logo
uses React.DOM
https://github.com/bhauman/devcards/blob/master/src/devcards/system.cljs#L503-L508
and that was removed
you may want to use js/React.createElement
I just built a Devcards Snapshot from master
and it’s choking on that
I’ll report anything else I find
actually let me fix that locally to see if that makes it work
this made it work for me
(also backwards compatible)
thanks
@bhauman can you deploy a snapshot with sablono 0.8.1-SNAPSHOT
?
thanks!
that’s working for me with React 16
even though @r0man didn’t release 0.8.1 yet, there’s the snapshot which works
no rush
@bhauman ooops another PR incoming, I’m sloppy and found more cases of React.DOM
let me grep the whole project
make sure I don’t mess this one up
@bhauman OK this is the last one, makes Devcards work with React 16 + a rather comprehensive collection of devcards https://github.com/bhauman/devcards/pull/130
sorry for the churn
@anmonteiro deployed 0.2.4-SNAPSHOT
thanks!