Fork me on GitHub
#cursive
<
2024-02-20
>
gtbono02:02:25

hey @cfleming is better support for matcher-combinators planned for some next releases?

cfleming02:02:07

Yes, I made some changes a while back and have more planned.

cfleming02:02:42

If there are specific things that you’re missing, please let me know and I’ll make sure they get addressed.

gtbono00:02:40

I can elaborate better later but the test output when using match? does not open the diff tool when a mismatch occurs (like when using clojure.test)

cfleming00:02:19

Ok, I’ll have to check my notes. I remember looking at this, but IIRC it’s not always clear what the two sides of the diff should be when using match?

gtbono00:02:25

you mean which side is the expected data and which is the actual data?

cfleming00:02:39

If I remember correctly (not sure, it’s been a while), there aren’t even always two clear sides - I might be remembering that wrong though.

gtbono00:02:19

I will try to know more about this and get back to you!

cfleming00:02:51

Thanks, like I say I need to check my notes as well, I’m not 100% about this, but I remember it was tricky.

andrioni14:02:08

cc @U02G8N0EX44, but I think the biggest issue IIRC is that the error reporting doesn't show up in the REPL pane and only sometimes when mousing over the failed test this was https://github.com/nubank/matcher-combinators/issues/31 on matcher-combinators

👍 2
Phillip Mates15:03:23

Hey, just seeing this (was traveling). While I don't use Cursive and don't know exactly what doesn't work, a few of my colleagues do (cc @U0AD3JSHL), and I help maintain matcher-combinators, so let me know if there is a way I can help.

Phillip Mates15:03:07

I don't think a diff window will be easy to integrate with the matcher-combinators output because for the actual of the clojure.test result, it provides the datastructure with mismatch information placed in the datastructure iteself

Phillip Mates15:03:08

some clojure.test/cursive issues that might be related to also how matcher-combinators is handled by cursive: - https://clojurians.slack.com/archives/C0744GXCJ/p1557445213127100 - https://github.com/cursive-ide/cursive/issues/875 and also someone came up with tweaks for a better failure printing w/ cursive: https://clojurians.slack.com/archives/C0744GXCJ/p1666881823365809