Fork me on GitHub
#calva
<
2024-02-20
>
Stefan12:02:18

Hi Calva friends! I'm still loving Calva very much, but recently there has been something EXTREMELY annoying. I know that every love relationship has those things, but it would be great if this one could be fixed 🙂 It's about "eval on save". I always work with at least three panes in VSCode: on the left I have the Calva repl out, in the middle I tend to have the unit tests, and on the right the production code. Recently (maybe last release because of https://github.com/BetterThanTomorrow/calva/issues/2389?) there was a change that unsaved files all of a sudden automatically get opened at strange times. Important context: I have both "auto save" set to "on focus change", and also Calva's "run on save" enabled. So now I have (unsaved) changes in my test file, I go to the other pane to edit the production code, and all of a sudden my test code is also opened on the right. Or I have unsaved changes, I command-click a symbol to go to a definition, and boom I'm right back where I came from because the changes got saved, code eval'ed, and then the file displayed again. I hope my rambling is making sense. Can this be fixed?

pez12:02:06

Yeah, we should fix this. Issue please! 🙏

👍 1
pez13:02:12

Hopefully this PR fixes the issue: https://github.com/BetterThanTomorrow/calva/pull/2403

🎉 1
❤️ 1
calva 1
🙏 1
Stefan13:02:47

Yes that seems to fix it!

🙏 1
thomas15:02:28

wow.... so at 13:39 a problem gets reported and at 16:03 a fix is released?

pez15:02:15

Haha, yeah, when a regression is quickly found and reported, it is easier to be quick about it, because the change is fresh in mind. And also @stefan.van.den.oord was quick to test that the PR fixed his issue. Sometimes fixes get hanging a while because we’re giving it some time to be tested by those who experience the issue. Unfortunately it is a bit uncommon that we actually get help with testing. Anyway, thanks for noticing! ❤️

Stefan16:02:04

And don't forget about you and your team having setup great CI so that I actually could immediately and very easily test the vsix @U0ETXRFEW!!

metal 1
pez21:02:27

I am super happy with our CI! Really great that @U9A1RLFNV wasn’t happy enough with it. 😃

😄 1