Fork me on GitHub
#code-reviews
<
2015-11-29
>
revivek22:11:34

Wrote my first bit of code in Clojure—a 50 LOC scraper—would love feedback on it simple_smile x-posted in #C053AK3F9 Code: https://gist.github.com/revivek/d6559b3fd5b9f661e095 Output (pprinted): https://gist.github.com/revivek/2f61bb8a1fe3311377ea

martinklepsch23:11:08

@revivek: consider map literals instead of hash-map

martinklepsch23:11:03

@revivek: also check partition vs partition-all

martinklepsch23:11:52

@revivek: (:require …) can contain multiple namespace requires

martinklepsch23:11:09

@revivek: use of dynamic vars seems unnecessary

martinklepsch23:11:36

(sorry for being so brief, typing w/ one hand simple_smile)

revivek23:11:17

@martinklepsch: super helpful—thank you!