spec made me use derive for the first time in 7 years 🍾

@mpenet What did it solve? :)

trying a new approach to generate json-schemas from specs, I have a registry of specs/preds -> json-schema forms that's a multimethod and that allows me to have some form of inheritance

Can you show an example? I'm not sure what json-schema is or how you convert from spec to json-schema.

json-schema is the format used by swagger/open-api

well part of

does the end result look different than the spec-tools conversion? (also uses a multimethod, but no inheritance atm)

not sure, I didn't look into spec-tools internals too much. What do you mean by end result?

code is here, but here be dragons, it's wip: https://github.com/mpenet/spex/blob/master/src/clj/qbits/spex/json_schema.clj

mapped all the predicates that have a clojure.spec generator, with those “rules”, here: https://github.com/metosin/spec-tools/blob/master/src/spec_tools/json_schema.cljc

looks very similar, but to be able to use derive you need to have ns'ed keywords

the same can be achieved with a macro tho, nothing too fancy

stuff I did is also an experiement with CLJ-2112

I am using a slightly modified/fixed version of that patch

@ikitommi That's a nice lib 👍

derive looks nice. should we at some point merge the working stuff into XYZ? would like to copy-paste the some of the missing mappings from Spex already.

feel free to do that, spex is just a test-bed really

seems like spec-tools covers a lot more already tho

it’s missing the Coercion protocol (instead of dynamic conforming), after it I’m kinda happy with what tries to resolve. the “drop-extra-keys from maps” things etc.

the 2112 would be awesome, it’s messy without that. Just realized yesterday that one can use and and or with s/keys...

these are different approaches really, spec-tools seems to wrap all specs with it's own types to add "metadata", coercion etc, I just force the user to register its specs (and provide some defaults) and don't bother with coercion at all at this level (imho these are 2 different things)

@yonatanel thanks!

spec-tools is full of cool stuff, didn't see the spec maps format thing

yeah or/and in keys is a bit of a pita, not sure it's feasible to translate in json-schema

CLJ-2112 code conforms it happily, but it's just ignored for convertion down the road

spec-tools doesn’t force to wrap into own records, JSON Schema is extracted from normal spec forms. Own records can be used to add metadata.

I guess for or/and in keys one should/could just flatten all of it when generating a schema

I think I like spec-tools approach better, records make all of this way nicer internally, too bad core.specs are not defined this way