I thinks it is a google closure problem, just tried the following:

java -jar ~/bin/closure-compiler-v20170218.jar --module_resolution NODE --js src/libs/npm_stuff.js --js_output_file test.js --process_common_js_modules true
src/libs/npm_stuff.js:1: WARNING - Failed to load module "styled-components"
var Styled = require('styled-components');
    ^

src/libs/npm_stuff.js:1: WARNING - Failed to load module "styled-components"
var Styled = require('styled-components');
             ^

0 error(s), 2 warning(s)

This is a different error because it does not traverse node_modules ofcourse.. 😅

@mitchelkuijpers I'm giving a talk on ClojureWest about compiling node modules specifically going through the low level details of how it works.. Do you mind if I use the bug you've found as an example of why this is useful?

@spinningtopsofdoom that sounds like it’s gonna be an interesting talk 👍

Hopefully BTW I'm including you in my thanks for you post on Parameterizing ClojureScript Builds

😊 — were you giving a talk at bobconf in january btw?

@spinningtopsofdoom FWIW I recently tried using some module stuff too but ran into an issue with things being used before they got defined: https://github.com/martinklepsch/weekly-log has a repro and instructions. Did you stumble into anything like that during the research for your talk?

@spinningtopsofdoom No problem at all

@mitchelkuijpers ofc that's not gonna work

You need to include the entire paths

@martinklepsch did you try running that with Closure from master?

And this PR applied: https://github.com/google/closure-compiler/pull/2350

@anmonteiro Yeah i found that out, this was the first time playing with the google closure compiler

@anmonteiro yes tried with Chad’s branch

@mitchelkuijpers the interestig thing is that it works if you require supports-color directly

Did not rebase it against master first I think though

So will need to look into that

@martinklepsch hrm might be better to try that first

Oh really? maybe it has something todo with the umd wrapping stuff or something..

But that is definitely interesting

@martinklepsch https://github.com/ChadKillingsworth/closure-compiler/commit/9e9f1abd86a594b27e10bbf723505ee517e192cc.patch

Apply that patch on current master with git am < /path/to/patch and build again

If it still doesn't work make sure to ping me so I look into it on the weekend!

I cherry picked 9e9f1ab into current master and rebuilt Closure. Same issue 😕 @anmonteiro

OK I’ll look into it soon!

<rant> people excited by a 1 KB drop in React, but most don’t acknowledge what Closure can do for them https://twitter.com/kentcdodds/status/844542288877539328 </rant>

heh