cross posting from re-frame since i was told i might have better luck here

hi all , does anyone here know how to implement the android part of this react-native-plugin (https://github.com/zo0r/react-native-push-notification ) in re-frame i have seen a bunch of examples that all only seem to implement the iOS part i cant see how to implement the class override specifically i know it mentions only if i did not use the link command manually , just not sure if that applies to re-frame or not, referring to this statement [Manually register module in MainApplication.java (if you did not use react-native link)]

@rc1140 We're using it and just using normal interop works well for us. Maybe you could share your code?

@vikeri hi , will try and get it uploaded now , but i didnt do much aside from create a new re-natal project and follow the instructions on the repo page

i think it may be related to the version of the google play gcm lib , but im not sure what version i should be using

i setup the require using this code , https://github.com/tiensonqin/lymchat/blob/master/src/lymchat/shared/ui.cljs

line 112

the https://github.com/zo0r/react-native-push-notification#android-manual-installation section seems to pretty clearly document how to add Android support. Are you getting an error of some sort or a specific question about how to make the changes to the Android project?

so i manually checked the MainApplication.java file and the required imports etc are there

but the anon function for registration of a token never fires

and calling (.localNotification push-notification {params here}) to test it fails as well with , can not read property call null of undefined

which from what i understand means the location notification call is not working

used this as an exmaple on how to do the configuration

https://github.com/tiensonqin/lymchat/blob/713257c48cf2188b45172a52aac4d68b481ea6f5/src/lymchat/android/core.cljs#L219

did you call re-natal use-component after adding react-native-push-notification?

yup

https://github.com/drapanjanas/re-natal#using-external-react-native-components

(from my history) , re-natal use-component react-native-push-notification

as far as i can tell there is no component part

looks like you didn’t include the com.google.android.gms:play-services-gcm dependency

i did as well , but thats what i was asking about earlier

regarding the version

in the docs they use 8.1.0 i think

I’m not seeing it in https://github.com/tiensonqin/lymchat/blob/master/android/app/build.gradle

i dont know if thats old

thats not my app sorry

let me just push my code

2 mins

you should stick with the same google services version

sorry for the delay

ok then i have that in place

9.4.0 if it’s the same as the linked gradle

yeah your latest code would be best, looks like AndroidManifest.xml is missing some stuff too but not sure if you have it locally?

yeah i added that

basically followed the readme

ok here you go , https://gitlab.com/rc1140/canary-echo

let me know if you spot anything

just glanced through all the android configuration and it seems fine

i also expect a println from the onRegister here , https://gitlab.com/rc1140/canary-echo/blob/master/src/canary_echo_mobile/android/core.cljs#L26

if you re-build with figwheel, you don’t see any errors?

but that never fires

no errors sadly 😞

initialy i was getting errors because of not having the use-component part

but you see setting up notifications?

yup

after that its a dump of the push-notification object

setting up notifications
figwheel-bridge.js:172 #js {:handler #object[NotificationsComponent [object Object]], :onRegister #object[Function "function (token){
return cljs.core.println.call(null,token);

like that

obviously snipped for verbosity

I wonder if you need this

(def push-notification (.-default (js/require "react-native-push-notification")))

(def push-notification (.-PushNotification (js/require "react-native-push-notification")))

let me try quickly if you dont mind waiting a bit

I’ll be here all day 😉

if neither one of those work, try .-Notifications

second option got , Cannot read property 'configure' of undefined

i have my money on .-Notifications

nope none of the options worked in that they all return a null object

which causes the configure to fail to run

it’s weird that it’s just printing

i’ll have to take a look again in a bit

its driving me insane 😞 , should be so simple

btw this is the full dump of the println of the push-notification

https://pastebin.com/iLaU2bX7

yeah, you had it right first, i didn’t catch that it was actually calling your onRegister

its not calling the onRegister

the println im talking about is from later in the code

that output comes form line 41

got it

onRegister is false in your printout… :thinking_face:

there is a _onRegister late

r

that’s not the one you’re trying to set though

that’s this one https://github.com/zo0r/react-native-push-notification/blob/master/index.js#L189

shrug i am honestly not sure

that’s the internal _onRegister that calls yours if it’s set

for some reason your call isn’t registering first

the ideal solution would be to include your configure in a re-frame effect i would think

surely at this point thats just semantics

as in the call doesnt seem to be working as expected

the effect part? yes mostly

so where it is wont help

but it seems like you might be at least observing a race

gonna wait on @vikeri at this point , im pretty KO and not getting this working is just frustrating

yeah i’m interested to find out what’s going on

one last suspicious piece is that you’re importing a mutable js object and i’m just not sure how that ends up translating

also every example has been demonstrated using ios , really wonder if it even works with android

yeah not sure about that at all

anyway thanks for all the help

`(defonce Notification (js/require "react-native-push-notification"))`

[/giphy ahhhhh]

And (defn dispatch-notification! [body] (.localNotification Notification (clj->js body)))

Is what we're doing. Sorry for the formatting. I'm on mobile

gg

I’m going to need to do this soon too so thanks @vikeri

@benny I can't say my contribution was substantial but if it worked then great 😉

i should have known to use defonce but i’m assuming knowing what i do that could get @rc1140 what he needs