Ah… when classnames.inc.js is loaded, it doesn’t define window.classNames. Instead it defines module.exports.

@juhoteperi: with the new closure compiler what does this mean for our existing cljsjs packages, how do we upgrade?

@flyboarder: I don't think there will be a one-size-fits-all type solution. Currently thinking that maybe we investigate how to package react and maybe 1-2 other popular ones and provide these with a -closure modifier

@flyboarder: still lots to figure out (for me at least)

Yeah I just want to make sure I'm going in the right direction

I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff

I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff

I want to package react-google-login, is there a sort of "absolute beginners guide to cljsjs packaging" that I could reference?

@emccue here you go: https://github.com/cljsjs/packages/wiki/Creating-Packages

Should I make cljsjs packages for all npm dependencies of the lib I'm re-packaging?