Fork me on GitHub
#cljsjs
<
2017-01-29
>
pupeno00:01:50

Ah… when classnames.inc.js is loaded, it doesn’t define window.classNames. Instead it defines module.exports.

flyboarder02:01:03

@juhoteperi: with the new closure compiler what does this mean for our existing cljsjs packages, how do we upgrade?

martinklepsch03:01:54

@flyboarder: I don't think there will be a one-size-fits-all type solution. Currently thinking that maybe we investigate how to package react and maybe 1-2 other popular ones and provide these with a -closure modifier

martinklepsch03:01:12

@flyboarder: still lots to figure out (for me at least)

flyboarder04:01:56

Yeah I just want to make sure I'm going in the right direction

martinklepsch05:01:56

I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff

martinklepsch05:01:46

I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff

emccue05:01:13

I want to package react-google-login, is there a sort of "absolute beginners guide to cljsjs packaging" that I could reference?

pupeno11:01:12

Should I make cljsjs packages for all npm dependencies of the lib I'm re-packaging?