Fork me on GitHub
#cljs-dev
<
2023-09-29
>
dnolen00:09:54

Yes tho you can probably version detect and macroize

thheller05:09:26

@dnolen since I implemented full support for "exports" recently in shadow-cljs, all these styles are surprisingly common https://github.com/thheller/shadow-cljs/blob/master/test-env/node_modules/exports/package.json#L9-L12

😧 2
thheller05:09:39

I thought I could get away with not implementing wildcards, or the prefix style, but they are very widely used

thheller05:09:36

also this abomination https://unpkg.com/@babel/[email protected]/package.json, although this is not that common

😭 1
dnolen13:09:42

@thheller yes I saw all kinds of weird stuff, but really we only need this for top-levels anyway - happy to fix stuff as people report them, or for people to submit patches

dnolen13:09:03

the logic was pretty inscrutable before, but I think it’s now pretty easy to add these extra cases and write the unit tests