Clojurians
#cljs-dev
<
2018-07-10
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes13:07:58

An interesting side case from #clojurescript : If you have code like (let [#js [1] 3]), the JSValue is placed in the resulting compiler exception, since JSValue is not serializable (it is just a plain deftype), this evidently causes an issue in environments expecting exceptions to be serializable ( boot is evidently one). I wonder if catches people often enough to matter. :thinking_face:

dnolen13:07:44

I can’t remember why I didn’t use records here

darwin13:07:07

changing it to records would probably fix this issue as well: https://dev.clojure.org/jira/browse/CLJS-1898

darwin14:07:45

btw. I tried to change it to defrecord in the first patch and “I just noticed that some tests broke because of the defrecord change.”

mfikes15:07:29

Yeah, I repro’d the same as well, which was unexpected. Perhaps we would have to add a bespoke Serializable. I’ll write a JIRA for this as a minor enhancement so it is in the potential queue.