This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-06-25
Channels
- # beginners (33)
- # cider (40)
- # clara (28)
- # cljs-dev (38)
- # cljsrn (5)
- # clojure (197)
- # clojure-greece (1)
- # clojure-italy (7)
- # clojure-losangeles (1)
- # clojure-nl (10)
- # clojure-spec (32)
- # clojure-uk (154)
- # clojurescript (48)
- # core-async (33)
- # cursive (32)
- # datomic (19)
- # duct (1)
- # fulcro (10)
- # graphql (6)
- # jobs (1)
- # lumo (1)
- # mount (6)
- # off-topic (48)
- # onyx (12)
- # other-languages (2)
- # re-frame (77)
- # reagent (19)
- # reitit (4)
- # ring (5)
- # ring-swagger (18)
- # rum (4)
- # shadow-cljs (52)
- # specter (12)
- # tools-deps (47)
@dnolen next tools.analyzer conversion patch ready for screening https://dev.clojure.org/jira/browse/CLJS-2789
@ambrosebs thanks
@dnolen 1.10.335 still has the problem. I tried also bumping transit in clojurescript’s pom.template.xml
locally, and this resolves the issue
can someone check if this added test fails if the defrecord has fields? eg. (defrecord Foo [a b])
? https://github.com/clojure/clojurescript/commit/1c4eefac5050c8480137d69d3d5b65fd53478cb2#diff-c84cc8a7a54af2cb72b646081c45b477
don't have any of the JS engines setup on windows yet so I can't run the tests manually
I still get inference warnings when I remove the hack I have for this in shadow-cljs.
104 | (defrecord Foo [a b])
-------^------------------------------------------------------------------------
Cannot infer target type in expression (. other35066 -a)
--------------------------------------------------------------------------------
@kommen Can you confirm that the patch in https://dev.clojure.org/jira/browse/CLJS-2791 is the same as the change you found necessary?
I do wonder: could this break somebody else, who is relying on an older version of transit-clj?
@kommen @mfikes it seems to me that the AOT compiled transit-clj files are included by accident? its only supposed to AOT these classes https://github.com/clojure/clojurescript/blob/master/pom.template.xml#L289-L318
but given how clojure AOT works I think the other classes need to be excluded elsewhere
@thheller I tried to exclude transit-clj from the JAR but this always causes other problems for me - AOT doesn’t seem to support independent compilation? Maybe @alexmiller can say more but I just can’t get it to work.
ah right. I think once it starts loading AOT classes it only loads classes and doesn't switch back to loading .clj
files
@kommen ClojureScript has a hard dep on transit-clj now anyway - so using a lower version shouldn’t be expected to work
fair enough, it just was confusing to me since I only checked dependency resolution and classpath building, and it didn’t occur to the to look into what the clojurescript jar actually contains
yeah I really tried to avoid this situation but it doesn’t seem possible at the moment unless I hear otherwise about AOT
Something funky is going on in Canary with Fulcro and Transit. Will dig into it. https://travis-ci.org/chkup/fulcro/builds/396430022#L1302
Planck encountered the same Transit error, and it too was explicitly specifying an older Transit dep https://travis-ci.org/planck-repl/planck/builds/396439228#L646 Revising it to just use the dep that ClojureScript specifies. Running Canary across the board now.
Travis seems to be experiencing some sort of recent acute backlog, making it a little challenging to see if Canary is OK. I think it is, in general. 🙂
(https://www.traviscistatus.com, especially the "Backlog Linux Builds", and Canary timeouts)
Canary is now good https://github.com/cljs-oss/canary