This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-08-11
Channels
- # admin-announcements (1)
- # aws (2)
- # beginners (32)
- # boot (147)
- # capetown (1)
- # cider (11)
- # cljs-dev (45)
- # cljsrn (57)
- # clojure (187)
- # clojure-russia (5)
- # clojure-spec (97)
- # clojure-uk (33)
- # clojurescript (33)
- # cloverage (17)
- # clr (4)
- # conf-proposals (93)
- # core-async (6)
- # cursive (9)
- # data-science (1)
- # datomic (24)
- # defnpodcast (1)
- # devcards (3)
- # emacs (3)
- # hoplon (95)
- # jobs (1)
- # off-topic (7)
- # om (97)
- # onyx (32)
- # overtone (1)
- # parinfer (4)
- # pedestal (1)
- # proton (1)
- # protorepl (13)
- # re-frame (4)
- # reagent (10)
- # specter (14)
- # untangled (40)
@dnolen, I fixed CLJS-1515 and also noticed a failure in self-host-parity
:
Testing cljs.spec-test
ERROR in (conform-explain) (TypeError:NaN:NaN)
Uncaught exception, not in assertion.
expected: nil
actual: #object[TypeError TypeError: Cannot read property 'do_template' of undefined]
Testing cljs.clojure-alias-test
Ran 208 tests containing 17289 assertions.
0 failures, 1 errors.
Just to bring it up š@richiardiandrea: The issue above is http://dev.clojure.org/jira/browse/CLJS-1731
Iām having compilation issues with clojurescript version 1.9.183
(with the :rename
feature).
When requiring om.next
.
Here are my dependencies:
:dependencies [[org.clojure/clojure "1.9.0-alpha10"]
[org.clojure/clojurescript "1.9.183"]
[org.omcljs/om "1.0.0-alpha36"]]
And here is a github repo that reproduces the issue: https://github.com/viebel/tiny-cljs-build/tree/4607a2034f68eb9ec739c76bbe0e8987f444e61c
When running lein cljsbuild once
, the error I get is:
Caused by: clojure.lang.ExceptionInfo: contains? not supported on type: clojure.lang.PersistentList at line 19 resources/public/dev/js/om/util.cljc {:file "resources/public/dev/js/om/util.cljc", :line 19, :column 1, :tag :cljs/analysis-error}
@anmonteiro: any idea?
@anmonteiro @dnolen the :rename
has a problematic case in :refer-clojure
for things that are macros as well as functions
the first produces cljs.core._PLUS_.cljs$core$IFn$_invoke$arity$2((1),(2));
while the second is ((1) + (2));
@viebel any idea where the resources/public/dev/js/om/util.cljc
is even coming from since it is not in your repo?
@thheller: resources/public/dev/js/om/util.cljc
comes from org.omcljs/om
Upgrading om
version to 1.0.0-alpha41
solved the issue
I think this commit https://github.com/omcljs/om/commit/1db2ca549fe6d2de2cf5b9d91fd854d5275104eb fixes the issue
But I donāt know why ?!!??!
@anmonteiro: maybe you know why?
@thheller: @viebel thanks for reporting, I'll look into both when I have time
@dnolen: If you end up applying self-host patches, I think one or more may conflict with the othersāmaking them not git apply. If so, just ping me and I can rebaseline the affected patch.
@anmonteiro: The change for CLJS-1716 caused a regression in self-host ability to (require '[clojure.spec :as s])
and then use macros in the cljs.spec
namespace. (I havenāt created a minimal repro involving no downstream tooling yet.)
@mfikes: hrm, I'm happy to look at a repro for that one
I wonder why self parity tests didn't fail?
Or was that not covered in the tests?
@anmonteiro: Iāve written a ticket with a proposed new unit test covering the issue mentioned above. http://dev.clojure.org/jira/browse/CLJS-1737
Uhm, I am trying cljs master and for some reason in replumb
's node repl I get:
cljs.user=> (require '[clojure.string :refer [trim]])
No such namespace: cljs.string, could not locate cljs/string.cljs, cljs/string.cljc, or Closure namespace "cljs.string"
I know that now we have aliases, but I see that node/js/compiled/out
contains string.js
so I wonder why it says it is missing...@richiardiandrea: You are seeing a consequence of logic to, upon failing to load a clojure.*
namespace to fallback trying to load a cljs.*
namespace: https://github.com/clojure/clojurescript/blob/16af9f651f09e5c3f91098270ffacb806b907302/src/main/cljs/cljs/js.cljs#L333-L336
So, the underlying question is: āWhy is clojure.string
not loading for you?ā (I tried your require
downstream with Planck master which is built against near-master of ClojureScript and it works there.)
uhm, weird, it is working solid with cljs 1.9.93
I'll investigate then, thanks a lot Mike
funnily enough, the commit 4e50980
(`1.9.94`) right before the aliasing patch is working fine
@richiardiandrea: I added [clojure.string :refer [trim]]
to the :require
block of the ns
form for cljs.clojure-alias-test
and ran script/test-self-parity
with no ill consequences. (You may be on to something, just sharing it canāt be reproād this way.)
@anmonteiro: let me know if youāre gonna take http://dev.clojure.org/jira/browse/CLJS-1733, I may give it a go tomorrow, thatās the last thing Iād like to get in before a release
@mfikes: very weird I will try browser too and report, after the release anyways, it does not seem a quick check/fix
And it can be a replumb bug that surfaced only now of course
@dnolen: FWIW I think there are plenty of low-priority funky corner cases in Spec under self-host yet to be ironed out that are best saved for a subsequent release.
@dnolen: I can't promise I'll have time to look at it tomorrow. In any case I'll let you know in advance