Clojurians
#cljs-dev
<
2015-09-02
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

juhoteperi22:09:26

@dnolen: I have somewhat working build with the new functions

juhoteperi22:09:48

Should I add patch to Jira for review? And should I include the alternative build implementation on that or only the functions?

juhoteperi22:09:16

It's still missing support for finding the sources for any Compilable (it will require a change it the protocol / new protocol) but I think review would be useful now

martinklepsch23:09:01

@juhoteperi: are all those functions completely new?

martinklepsch23:09:28

@juhoteperi: If build-new replaces build it’s probably best to have that reflected in the patch making reviewing it easier :simple_smile:

juhoteperi23:09:40

Well yeah, except for build-new, which is there for testing and demonstration, they are new functions. The logic has been copy-pasted from various existing functions where finding namespaces and compiling them is currently done at the same time.

martinklepsch23:09:28

Ok cool, anyways it was just a quick thought :simple_smile: Nice work! :+1:

martinklepsch23:09:32

And good night :simple_smile: