@alex.sheluchin I think we could add a dependency to that project with community aliases instead of building them into clj-kondo, like you requested. This seems more flexible

So then you can add io.github.clj-kondo/config-bbatsov-clojure-style-guide to your deps and it will "just work"

I see @seancorfield also accepted a PR in that repo. Do you think that would be a good idea?

@U04V15CAJ Thank you! I think this is a fine approach for my use case. @UEENNMX0T raised a concern about using it in this way when installing clj-kondo as a bin rather than a project dep. Will a bin kondo not pick up on configs installed this way? I'm not sure I fully understand the difficulty there.

there is no difference between binary or JVM clj-kondo

I think an automated checker for the style guide would be awesome, if it's possible.

I noticed that Alex uses jio a lot for so I think there will never be 100% consensus about these things, I'd rather leave it as an optional library than baking it in

The library comes from here: https://github.com/clj-kondo/configs/tree/main/configs/bbatsov/clojure-style-guide-aliases If you want to provide more configurations for other libraries that you don't manage yourself, then this is the place to do so, if the original maintainer doesn't want to have it in their repo

Nice! I'll take a look at that when I get back to work on Monday.

Thanks for the instruction, @U04V15CAJ. I'll probably have time to try it tomorrow. I'm planning on showing a breakdown of aliases per namespace so maybe that will help promote a consensus, but it'll probably never be 100%. That's okay, choice is good :man-shrugging:

We only have a few standard aliases at work, for third party libs (we have quite a few for our own nses):

clojure.data.json json
    clojure.spec.alpha s
    clojure.string str
    com.stuartsierra.component component
    exoscale.coax c
    next.jdbc jdbc, next.jdbc.result-set rs, next.jdbc.sql sql
    ring.util.response resp

Of course you can configure your own with :consistent-alias as well

And that would override the style guide ones?

:linters
 {:consistent-alias
  {:aliases

Yes, your own would override but with merging

@U04V15CAJ works nice 👍 thank you. I guess I can close https://github.com/clj-kondo/clj-kondo/issues/1839 as completed?

ok, maybe make a comment in there that this is the solution we landed on

and then close it

done and done. ty sir

Seems to work nicely -- thanks! I was a bit surprised that clojure.data.json wasn't aliased to json but it isn't in the guide (only because cheshire.core is aliased to json lower down and I didn't want to introduce a conflict when I did that).