Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2018-05-23

Channels

#cider
<
2018-05-23
>
bozhidar04:05:48

@benedek Well, it won’t be. I’ll have to change the namespaces there as well. Not sure if I’ll do it in 0.18 or 0.19. Mostly depends on the how soon we’ll get to the point we can jack into the new nREPL.

benedek08:05:37

Ok bit confused now. So i dont need to change this for refactor-nrepl to make it compatible with cider-nrepl latest snapshot?

benedek08:05:52

Right now i mean

bozhidar09:05:43

I can’t rename the namespaces before we’ve got something we can use for cider-jack-in.

benedek09:05:43

Ah right. Ok.

skrat10:05:59

Hai, I have an issue with cider-test-run-focused-test, it throws Uncaught exception java.lang.IllegalArgumentException: Symbol must be namespace-qualified on nREPL-worker-32

skrat10:05:15

cider-test-run-ns-tests works just fine

dominicm10:05:37

@skrat are you on 0.17 snapshots?

dominicm10:05:16

@skrat please update to 0.18 snapshots or 0.17 stable

skrat11:05:33

@dominicm yepp, it does work with 0.18, thanks

dpsutton13:05:07

so I've gotten a bit further with the fighweel and cider/piggieback failing to find the repl. I can trace it to when piggieback tries to initialize the cljs repl with the repl macros like source, doc, etc. This function also plucks some stuff out of the environment for piggieback to use. As far as I can tell this function never returns.

dpsutton13:05:39

The repl-env it is using is > #object[breeze.jib.server.core.Delegatingfigwheel_sidecar_repl_FigwheelEnv 0x10342283 "breeze.jib.server.[email protected]"]

dpsutton13:05:01

so for whatever reason this is either dying silently or is not notifying anything when its done

bozhidar16:05:53

You should report this to @bhauman.

bozhidar16:05:01

Likely it’s not something new.

bhauman16:05:58

@dpsutton is there a trace to go with that?

dpsutton16:05:25

no that's all lein installing with prn's involved

dpsutton16:05:06

i can get cemerick/piggieback 0.2.2 with lein-figwheel 0.5.14. i can't get cemerick's version with any more recent figwheel. and i can't get cider/piggieback with any figwheel

dpsutton16:05:35

this is our primary work product. so i'm staying on 0.5.14 and 0.2.2/cmerick for now. i'm gonna bisect across figwheel to see where things go wrong for me

bhauman16:05:37

@dpsutton how are you actually starting figwheel?

bhauman16:05:09

are you just calling figwheel-start? and cljs-repl?

dpsutton16:05:13

cider-jack-in-clojurescript so 

(do (require 'figwheel-sidecar.repl-api) (figwheel-sidecar.repl-api/start-figwheel!) (figwheel-sidecar.repl-api/cljs-repl))

bhauman16:05:32

is a connection made in the console?

dpsutton16:05:55

not sure how to check that. what should i look for. the app starts and works. just the emacs repl buffer never moves past Prompt will show when Figwheel connects to your application

dpsutton16:05:14

i never see > To quit, type: :cljs/quit > nil > cljs.user>

bhauman16:05:20

oh i meant the devtools console?

bhauman16:05:32

does it say it connects?

dpsutton16:05:33

don't have them installed. one sec

dpsutton16:05:46

sorry i misunderstood. one sec

bhauman16:05:13

I'm thinking you are going to see an error

dpsutton16:05:23

so with cemerick/piggie 0.2.2 and lein-figwheel(and sidecar) 0.5.16 i get no error in the console

dpsutton16:05:39

app is alive and working

dpsutton16:05:06

if i go back to 0.5.14 with no other changes i get connected

dpsutton16:05:15

that's the best diff i can get between working and non-working

dpsutton16:05:43

and by the way if i'm taking up too much of your time i'm planning on rooting around in this tonight as well

dpsutton16:05:03

and i appreciate your projects and your time 🙂

bhauman16:05:21

Is there a comfirmation that figwheel connects in with piggie 0.2.2 and figwheel 0.5.16

dpsutton16:05:35

no. that is lacking. i only get that with figwheel 0.5.14

bhauman16:05:02

So figwheel is not getting injected in your build somehow

dpsutton16:05:16

for me 0.5.14 works with cemerick piggieback. 0.5.16 doesn't work with either cider/piggie or cemerick/piggie for me

bhauman16:05:27

are there any messages from figwheel at all in the console?

bhauman16:05:06

no in the devtools console?

dpsutton16:05:14

none at all

bhauman16:05:26

ok figwheel isn't getting injected in the build

bhauman16:05:40

sounds like a crazy ass caching issue

bhauman16:05:10

because there is no way that figwheel isn't getting injected in the build

bhauman16:05:41

please make sure that you delete ./cljs/

bhauman16:05:03

completely clear your caches

bhauman16:05:12

delete all artifacts

bhauman16:05:14

and add :cljsbuilds > [build-id] > :figwheel > :debug true

bhauman16:05:12

I'm really not understanding how this could be happening

dpsutton16:05:40

i've deleted target/ ~/.m2

bhauman16:05:52

and ~/.cljs ?

dpsutton17:05:06

done. anything else?

bhauman17:05:52

well there's your browser cache but let's hope that's not it

dpsutton17:05:54

and added debug true

dpsutton17:05:03

i tried in firefox as well which has never run the app

bhauman17:05:51

Mainly looking for messages from figwheel in the console

dpsutton17:05:55

i'm surprised ~/.cljs could be implicated in this

dpsutton17:05:03

unless that was a better safe than sorry

dpsutton17:05:15

i'm starting up again. we'll see

bhauman17:05:25

I'm not, all you have to do is compile figwheel once with the wrong compiler version

bhauman17:05:20

also what version of cljs are you using?

dpsutton17:05:20

no messages in console 😞

dpsutton17:05:06

backing to figwheel 0.5.14 i get the debug messages. the only change is figwheel version

dpsutton17:05:53

i'm gonna try to bisect tonight

richiardiandrea18:05:15

in the port of the repl things, it is actually interesting to see what will happen to this: https://github.com/clojure-emacs/cider/blob/master/cider.el#L141

richiardiandrea18:05:29

because we could use a custom task for nrepl

richiardiandrea18:05:01

just open a weird PR that I will continue later 🙂 https://github.com/clojure-emacs/cider-nrepl/pull/532