Fork me on GitHub
#cider
<
2018-05-20
>
bhauman15:05:12

keep in mind that @darwin has done a massive amount of nREPL middleware work with his https://github.com/binaryage/dirac

bhauman15:05:15

It would really be great if we didn't make breaking changes for only aesthetic reasons

theeternalpulse15:05:11

when I do cider-connect-clojurescript it asks me to associate with a project, it doesn't seem to do this with cider-connect (clojurescript). Does it infer something different with clojure projects vs clojurescript ones?

soulflyer16:05:33

Just started seeing this error when I do cider-jack-in:

WARNING: CIDER's version (0.18.0-snapshot) does not match cider-nrepl's version (1.0.0). Things will break!
I'm using the latest version of cider, and as the repl starts I see it is using cider/cider-nrepl "0.18.0-SNAPSHOT" not 1.0.0. This project was working fine a few hours ago. Doing a package update of cider (I was a day behind) didn't change anything. Any ideas?

bozhidar16:05:30

@soulflyer Hmm, that’s an unexpected bug - the result of me trying to remove some version duplication using https://github.com/trptcolin/versioneer

bozhidar16:05:02

This was supposed to extract the version of cider-nrepl from the artifact’s metadata.

bozhidar16:05:34

You can ignore the warning. I’ll revert the change if I can’t figure out what went wrong.

bozhidar16:05:31

> It would really be great if we didn’t make breaking changes for only aesthetic reasons (edited)

soulflyer16:05:48

So it should still work ok? My project is no longer working, looks like none of my re-frame :events are getting registered. Maybe I broke something unrelated...

bozhidar16:05:48

@bhauman Sure. Generally I just want to avoid having to test on a huge build matrix and have to do weird compatibility tricks. I’m fine with maintaining Clojure 1.7 if someone starts complaining about this, but I really don’t think we need to bother with JDKs that have reached their EOL 5 years ago.

bozhidar16:05:30

@soulflyer I can’t imagine how this can be the problem. It’s a one-liner type of change.

bozhidar16:05:12

It’s a pity that it’s so hard to be able to leverage the project’s version declaration internally. 😄

soulflyer16:05:34

Ok thanks, will keep digging and ignore the nrepl error

bozhidar16:05:13

@soulflyer I’ve reverted this change, btw. A new build will be up soon.

soulflyer16:05:29

ah-ha. all good now. clj-refactor had moved the subs :require out of my core.cljs. Absolutely nothing to do with cider-nrepl at all....

bozhidar17:05:23

Good to know! I’m happy you managed to sort this out quickly!

bozhidar20:05:42

@bhauman CIDER now injects piggieback automatically. Tomorrow I’ll clean up the code and make it more generic.