Fork me on GitHub
#cider
<
2018-05-16
>
stardiviner00:05:07

Can CIDER make cider-jack-in-dependencies support specify dependency like:

elisp
(add-to-list 'cider-jack-in-dependencies '("org.clojure/tools.deps.alpha" "{:git/url \"" :sha \"d492e97259c013ba401c5238842cd3445839d020\"}"))
I use this does not work. It jack-in with depdency like:
Starting nREPL server via clojure -Sdeps '{:deps {org.clojure/tools.deps.alpha {:mvn/version "{:git/url "" :sha "d492e97259c013ba401c5238842cd3445839d020"}"} org.clojure/tools.nrepl {:mvn/version "0.2.13"} refactor-nrepl {:mvn/version "2.4.0-SNAPSHOT"} cider/cider-nrepl {:mvn/version "0.18.0-SNAPSHOT"}}}' -e '(require (quote cider-nrepl.main)) (cider-nrepl.main/init ["cider.nrepl/cider-middleware"])'...

bozhidar06:05:59

@stardiviner Haven’t thought about such an use-case, so not really. Deps are supposed to be in the same format regardless of the tool used. That’s doable, of course.

bozhidar06:05:13

@andre.stylianos The snapshot is on clojars now. Btw, @bhauman you know you have deploy rights for piggieback, right? 🙂

stardiviner06:05:08

In function cider-clojure-cli-jack-in-dependencies I saw the version is hardcoded, can it be more extendable? let user can provide string? So that specify {:git/url \"" :sha \"d492e97259c013ba401c5238842cd3445839d020\"} is possible? Don't know other build tools like Leiningen seems can't support Git revision. Even though has external tools like lein-git-revision, but it will make CIDER too complex. Maybe until future one day clj + tools.deps.alpha can be used widely?

stardiviner06:05:31

Huuu, seems this solution is not good. forget it.

dominicm06:05:27

@stardiviner in this particular case, it may be notable that t.d.a is on maven

stardiviner06:05:55

What's "t.d.a"? Haven't found in dictionaries, and Google Translate.

dominicm06:05:41

I mean, tools.deps.alpha

stardiviner06:05:52

Aha, I see. 🙂

bozhidar08:05:44

@stardiviner When I wrote this tools.cli didn’t support git revisions. Generally this can be augmented, but I wonder what would be the value if 3 out of 4 tools we support can’t handle git versions.

stardiviner09:05:07

You're right, I think the same thing. 🙂

andre.stylianos08:05:26

Just tested the latest piggieback snapshot, working nicely!

bozhidar09:05:31

FYI - I just cut nREPL 0.3.0 which is mostly a cleanup/transitional release. I’ve changed the deployment artefact to cider/nrepl, but the namespaces are still the same and I’ll change those in next release as well back to nrepl.*. I just felt it was important to honour’s Chas’s plan for the transition, even if I doubt anyone will use 0.3.0.

bozhidar09:05:28

Some cleanup highlights: * nice travis setup * mvn -> lein * eastwood and cljfmt fixes

sashton22:05:49

@bozhidar With the move of nREPL to cider/nrepl, and the existence of the cider-nrepl middleware, do you have plans to help differentiate the names? Will the cider-nrepl middleware retain the cider branding?