Seems unlikely. Did you try to manually require it?

@dominicm No, frankly I haven’t tried anything about this. But I was brave and upgraded to Java 10 to test the classpath stuff. Somewhat funny Java 9 is already dead. 🙂

Btw, isn’t this just what you end up using by default? (just looking at the code and its history)

@bozhidar I don't see a require to the default namespace, where is it? Main usage is through the util namespace.

@kwcharllie379 I found the problem. There’s no require in the command CIDER uses for nashorn. If you changed this to "(do (require 'cljs.repl.nashorn) (cider.piggieback/cljs-repl (cljs.repl.nashorn/repl-env)))" it should work. I’ll update the default.

@bozhidar seems that node repl is broken by default as well

When node repl started then it immiedietly dies because of socket close

it’s broken on piggieback 0.3.2 for a different reason, try 0.3.3

Ok I will give it a try

@dominicm I guess you missed this line https://github.com/tobias/dynapath/blob/230f78f7b3023702926a978dc04aa81ec99fc93d/src/dynapath/util.clj#L4

@bozhidar I did, yep! Thanks.

@bozhidarre. migrating clean-ns over to cider: if this happens i would like the feature broken up (again) into subfeatures — so to say — so clients or users can run the whole shebang in one go OR just parts of it. like sort requires/imports only or remove unused only etc

@benedek Yeah, I agree.

I’d start with the simplest functionality and take it from there. E.g. whatever used to be slamhound doesn’t have any external deps, right? It’d be easy to move this over.

I’m not sure how removed unused is implemented currently, but I assume it’s not rocket science either.

I’m not very familiar with the code, so you’ll have to enlighten us as to what’s most feasible.

@bozhidar nashorn works well but the node repl still have some errors

When i try to evalute something in the repl I got

To quit, type: :cljs/quit
nil
cljs.user> '()

java.io.IOException: Stream closed
	at java.base/java.io.BufferedWriter.ensureOpen(BufferedWriter.java:107)
	at java.base/java.io.BufferedWriter.write(BufferedWriter.java:224)
	at java.base/java.io.Writer.write(Writer.java:162)
	at cljs.repl.node$write.invokeStatic(node.clj:47)
	at cljs.repl.node$write.invoke(node.clj:46)
	at cljs.repl.node$node_eval.invokeStatic(node.clj:66)
	at cljs.repl.node$node_eval.invoke(node.clj:61)
	at cljs.repl.node.NodeEnv._evaluate(node.clj:235)
	at cljs.repl$evaluate_form.invokeStatic(repl.cljc:553)
	at cljs.repl$evaluate_form.invoke(repl.cljc:484)
	at cider.piggieback$eval_cljs.invokeStatic(piggieback.clj:133)
	at cider.piggieback$eval_cljs.invoke(piggieback.clj:132)
	at cider.piggieback$do_eval.invokeStatic(piggieback.clj:159)
	at cider.piggieback$do_eval.invoke(piggieback.clj:140)
	at cider.piggieback$evaluate.invokeStatic(piggieback.clj:182)
	at cider.piggieback$evaluate.invoke(piggieback.clj:180)
	at clojure.lang.Var.invoke(Var.java:381)
	at cider.piggieback$wrap_cljs_repl$fn__1403$fn__1405$fn__1406.invoke(piggieback.clj:211)
	at cider.piggieback$enqueue$fn__1383.invoke(piggieback.clj:115)
	at clojure.tools.nrepl.middleware.interruptible_eval$run_next$fn__860.invoke(interruptible_eval.clj:190)
	at clojure.lang.AFn.run(AFn.java:22)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:844)

I will try to investigate what is wrong

@kwcharllie379 what piggieback version are you using?

0.3.3

With the newst clojurescript version

That looks exactly like the error I had on 0.3.2

or .1, not sure.

Maybe I will try to clean my deps wait.

Oh wait, I'm lying I think

node is known broken with 0.3.2+

aaaaaaa ok

I didn't open a gh issue though

I just pinged bhau man

Did you try to solve the problem?

@dominicm @bhauman fixed the problem you reported in 0.3.3

I didn’t really try the fix then, perhaps he didn’t fully address the problem.

Anyways, file a ticket.

No idea

That’s the relevant commit, btw https://github.com/clojure-emacs/piggieback/commit/cc48fe207d1fe2d90ce6ce6d87a1a2476b00cadb

@bozhidar @dominicm this is fixed in 0.3.3

Not according to @kwcharllie379 🙂

I will file a ticket. But I am trying to fix it know 😄

I'm thinking you have stale deps

because this is under test coverage

Ok so I will try to remove whole m2 and then check whether it works correctly

also your target directory and hope that you aren't bringing in AOTed code somehow

I flushed the target and m2 then still the problem occurs

Then I would conclude that you are pulling in the earlier version?

I will try to match my project.clj to the one which exists in piggieback

are you using the latest version of Cider?

@kwcharllie379 ^

and which versions of cider/piggieback are now in your .m2/repository

my cider version is 0.18.0-snapshot and the version of cider/piggieback is 0.3.3

wow

On which java version did you test?

let's make a minimal test case

Yeah I just did:

lein new figwheel nodepiggie

changed the cider/piggieback version to 0.3.3

changed the compiler options to

then did lein repl

actually that's not a minimal case

it was just easy to do

@kwcharllie379 OK I just got the error

sorry

I do not know how figwheel is connected to bare node 😛

I'm a bit confused as to what happend

I'm looking into it, again I apologize

Uff! That's good because I felt ashamed. 😄 Don't apologize I'm grateful that you're trying to help.

Firstly I thought that it's because of nvm but then I installed node system-wide. It's seems that repl wait's for the some input and when the input's goes through it immediately close.

I'm really confused tests that were passing are all failing now so I'm not sure what's going on

@kwcharllie379 dang it's the latest version of CLJS

it works for "1.9.946"

I'll have to use a ReplEnv wrapper again 😞

Ups :((

But then other bugs? Or slow?

@dominicm no slow down

just ugly

the problem is we need to fully initialize the repl and prevent it from calling tear-down which in now in a finally block

I should have seen this before

It's much work?

it's turning out to be but it needs to be done

almost finished

@kwcharllie379 if you install the cider.piggieback 0.3.4-SNAPSHOT locally it should work

@bhauman Will check it tomorrow. I have one question though: By locally you mean that I have to clone the piggieback repo to m2? I thought that it's already published to clojars but I do not see that version there.

clone piggieback locally to a temporary location, then run lein install to place it in your m2

@kwcharllie379 ^

howdy folks

long time user, but am interested in hooking into the test middleware

i want to play tones for passed or failed tests

anyone have a suggestion for where to start?

@devn easiest way I've found to do things like what you're asking is to use https://github.com/weavejester/eftest/ instead of the normal clojure test, you can then define your own custom report function which can call out to one of the built in reporters (like eftest.report.pretty), but also add your own code to run in addition