Hello, I just upgraded to cider 0.17.0 and noticed that the cider-cljs-lein-repl variable is deprecated/obsolete now. I used this variable to start a custom ClojureScript REPL. It looks like I can't customize this anymore and the only options I have to start a ClojureScript REPL are the ones defined in cider-cljs-repl-types. Could we restore the previous behaviour and add something like a "Custom" ClojureScript REPL type to cider-cljs-repl-types and make this type of REPL configurable with a variable like cider-custom-cljs-init-form again?

@r0man you can add your own commands by:

(add-to-list 'cider-cljs-repl-types '("Shadow CLJS" "(do (shadow.cljs.devtools.server/start!) (shadow.cljs.devtools.api/watch :app) (shadow.cljs.devtools.api/nrepl-select :app))" nil))

Which is actually pretty awesome you can create as many options as you like

@mitchelkuijpers yes I thought about this. But wasn't sure how to do this with .dir-locals.el. I was using a .dir-locals.el file checked into my project and I could just jack-in.

do you know if I can I somehow add to a list with dir-locals.el?

Yes that is exactly what I have hold on

((nil . ((projectile-project-type . lein-test)
         (eval . (progn
                   (require 'cider)
                   (add-to-list 'cider-cljs-repl-types '("Shadow CLJS" "(do (shadow.cljs.devtools.server/start!) (shadow.cljs.devtools.api/watch :app) (shadow.cljs.devtools.api/nrepl-select :app))" nil))
                   (setq projectile-create-missing-test-files t))))))

ah, cool, good old eval 🙂

thanks!

No problem at all I got this from @bozhidar

@mitchelkuijpers this works perfectly. thanks again! 🙂

oh, and the new diff in failing tests is also very nice. thanks for adding this!

@bhauman Can you please run the profiler for a bit while experiencing the slowdown?

Once we know what exactly is off we can easily fix it.

@bozhidar which profiler is there one in emacs?

got it

The build in one. You just start it, work for a bit and stop it.

It generates a very useful and simple report.

coolio

@bozhidar where should I send the report?

looks like clojure-project-dir got called more than 200 times in less than 40 keystrokes via cider--anchored-search-suppressed-forms

which was being called during fontlock runs

The suspense is quite engaging on this one.

@bhauman Just file a ticket and attach the report to it.

you got it, thanks

But it seems that your hunch is correct and this has something to do with the font-locking of reader conditionals.

today I got to use cider again after inf-clojure land and woa, so many goodies 😄

wondering if socket REPL is in the TODO list by someone already

it exists in the sufficiently large todo lists 😉

True that!

Now that orchard exists the only really big chunk of work is to sit down and write the low-level connection handling. After that’s done we’ll just add some connection-type dispatch for all commands and slowly start adding socket versions of the nREPL commands. At least this is how I’m envisioning the process.

It won’t happen overnight, but it’s not rocket science either - just a bit of boring extraction/abstraction cycles. 🙂

@nha Just set cider-font-lock-reader-conditionals to nil.

(I assume this is going to solve @bhauman’s problem as well, at least as a workaround)

Sounds like a good plan, actually probably less code then actually adding hooks and custom functions to my own inf-clojure.el conf file. The other interesting piece I have run against is how to detect that the socket repl (or any connection for that matter) has loaded/done the correct init stuff. In particular socket repls accept functions can do all sorts of stuff and I wonder if cider could generate them

Likely we’ll just add those to orchard and inject it when starting a socket REPL. You’ll still need the supporting functionality anyways, so I don’t imagine how you can achieve anything more than basic evals without throwing in some tooling library in the mix.

whoa orchard is really good to know about

for rebel-readline

Slightly off topic - has anyone played with running lein sorta as a server?

like running lein and connecting with cider-connect?