This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-05-14
Channels
- # beginners (19)
- # boot (28)
- # cider (1)
- # cljs-dev (12)
- # cljsrn (1)
- # clojure (246)
- # clojure-belgium (4)
- # clojure-berlin (1)
- # clojure-france (4)
- # clojure-italy (7)
- # clojure-russia (11)
- # clojure-serbia (3)
- # clojure-spec (5)
- # clojurescript (106)
- # cursive (4)
- # datomic (7)
- # emacs (1)
- # jobs (6)
- # leiningen (3)
- # luminus (1)
- # lumo (11)
- # off-topic (1)
- # om (7)
- # onyx (1)
- # pedestal (6)
- # re-frame (16)
- # reagent (4)
- # rum (3)
- # spacemacs (1)
- # unrepl (1)
- # untangled (5)
- # vim (1)
@juhoteperi i was checking an issue in boot-figreload
about asset-path. Do you think there is still a need for passing it to reload
or it can be completely delegated to .cljs.edn
files? I tend to like the latter now.
@richiardiandrea Everything but ids
option could be read from .cljs.edn
, and it would probably be a good idea
@currentoor originally reported it and to me removing the option asserts that you need a .cljs.edn
- without it things will break
So given that boot-figreload
is still snapshot...I am tempted of just take the option away 😀
Yeah removing most of the options would probably be good idea
Boot-reload has had quite a "option creep"
Hmh, looks like I have forgotten to release new Boot-cljs 😄
Though there is one unfinished PR
Just to double check with you: on-jsload
, asset-path
...Not sure then probably cljs-asset-path
?
I read the old PR quickly and I do not really understand it at the moment
Maybe I will leave it there for now
So @juhoteperi one thing I see https://github.com/boot-clj/boot-cljs/blob/a182013465bcd36504f48b9bf4a950b656cbf851/src/adzerk/boot_cljs/middleware.clj#L61
Is that asset-path
is always output-dir
So this means that boot-cljs
does not allow to specify that option
Which is fine, just wanted a confirmation
https://github.com/boot-clj/boot-cljs/blob/a182013465bcd36504f48b9bf4a950b656cbf851/src/adzerk/boot_cljs/middleware.clj#L85 That value is only the default, if user provides option in compiler-options
user provided value is used
Right, maybe I am doing smth wrong here then
Without maybe 😀😀
@juhoteperi I had :asset-path
under :boot-reload
keys
@currentoor pushed 0.1.1-SHAPSHOT
I guess boot-reload/figreload should just try to detect options from compiler-options
should be possible now that boot-cljs publishes the options in metadata
yep I see the option there, regarding asset-path
I don't think I need to do much more
if the compiler compiles right and the server
exposes the right directory, I checked the files are compiled including asset-path
, and hopefully figwheel will be able to figure out the right path 😄
Just pushed new Boot-cljs snapshot with :preprocess
support, I'll try to do new release this week after I have tested this with some projects: https://github.com/boot-clj/boot-cljs/blob/master/CHANGES.md#unreleased
Saapas has a example on how to use :preprocess
for JSX transformation: https://github.com/Deraen/saapas/commit/a4f261e8d5363933c7c065e81610fcccf4267078
@juhoteperi does this mean preprocessing for cljsjs will be available soon?