Fork me on GitHub
#boot
<
2017-05-14
>
richiardiandrea18:05:53

@juhoteperi i was checking an issue in boot-figreload about asset-path. Do you think there is still a need for passing it to reload or it can be completely delegated to .cljs.edn files? I tend to like the latter now.

juhoteperi18:05:26

@richiardiandrea Everything but ids option could be read from .cljs.edn, and it would probably be a good idea

richiardiandrea19:05:26

@currentoor originally reported it and to me removing the option asserts that you need a .cljs.edn - without it things will break

richiardiandrea19:05:06

So given that boot-figreload is still snapshot...I am tempted of just take the option away 😀

juhoteperi19:05:13

Yeah removing most of the options would probably be good idea

juhoteperi19:05:41

Boot-reload has had quite a "option creep"

juhoteperi19:05:28

Hmh, looks like I have forgotten to release new Boot-cljs 😄

juhoteperi19:05:46

Though there is one unfinished PR

richiardiandrea19:05:20

Just to double check with you: on-jsload, asset-path...Not sure then probably cljs-asset-path?

richiardiandrea19:05:58

I read the old PR quickly and I do not really understand it at the moment

richiardiandrea19:05:07

Maybe I will leave it there for now

richiardiandrea20:05:40

Is that asset-path is always output-dir

richiardiandrea20:05:05

So this means that boot-cljs does not allow to specify that option

richiardiandrea20:05:19

Which is fine, just wanted a confirmation

juhoteperi20:05:30

https://github.com/boot-clj/boot-cljs/blob/a182013465bcd36504f48b9bf4a950b656cbf851/src/adzerk/boot_cljs/middleware.clj#L85 That value is only the default, if user provides option in compiler-options user provided value is used

richiardiandrea20:05:45

Right, maybe I am doing smth wrong here then

richiardiandrea20:05:54

Without maybe 😀😀

richiardiandrea20:05:52

@juhoteperi I had :asset-path under :boot-reload keys facepalm

juhoteperi20:05:32

I guess boot-reload/figreload should just try to detect options from compiler-options

juhoteperi20:05:04

should be possible now that boot-cljs publishes the options in metadata

richiardiandrea20:05:34

yep I see the option there, regarding asset-path I don't think I need to do much more

richiardiandrea20:05:56

if the compiler compiles right and the server exposes the right directory, I checked the files are compiled including asset-path, and hopefully figwheel will be able to figure out the right path 😄

juhoteperi21:05:14

Just pushed new Boot-cljs snapshot with :preprocess support, I'll try to do new release this week after I have tested this with some projects: https://github.com/boot-clj/boot-cljs/blob/master/CHANGES.md#unreleased

juhoteperi21:05:28

Saapas has a example on how to use :preprocess for JSX transformation: https://github.com/Deraen/saapas/commit/a4f261e8d5363933c7c065e81610fcccf4267078

flyboarder22:05:56

@juhoteperi does this mean preprocessing for cljsjs will be available soon?