Is there some clean way of adding dependencies to a project (and the uberjar + pom built from it) from a custom-written task? set-env! or merge-env! successfully update :dependencies in the boot env but if you have a pipeline with uber and pom, those will use the dependencies as they were when constructing the pipeline - so prior to executing earlier tasks like the one that would add the dependencies.

@jannis I remember seeing something for this but I don't find it in the API docs right now. @micha will know. That said generally I think what you're trying to do might not be advisable since it affects dependency resolution and you might get different set of deps than if you'd run it without your task

@martinklepsch Yes, although that's kind of what I'm looking for. I may have found a better way though: have a function similar to bootlaces! that I call before the task definitions. That can then add the dependencies so it doesn't have to be done in a task.

Has anyone seen this error before, when building with boot (I think it's from aot): java.lang.ClassNotFoundException: java.util, compiling:(clojure/tools/reader/default_data_readers.clj:1:2)?

not seen it but general consensus around here has often been that avoiding AOT is best as long as you don't absolutely need it

Isn't it needed when building an uberjar for standalone execution?

yes but you can make a "shim namespace" that essentially does something like this:

(require ')
((resolve '))

then you only AOT that namespace which has zero dependencies and you don't get into any of the AOT related troubles

Let me try that quickly. 🙂

good luck 🙂

Thanks 🙂

https://github.com/adzerk-oss/boot-uberjar-example/blob/master/src/main/Main.java @jannis

@dominicm whats the benefit over the clj approach?

Ok, that worked (compiling at least). Let's see if it runs.

@martinklepsch my understanding is that it's simpler to understand, but I might be wrong. I know the equivalent clojure code might be considered confusing. I think it was mostly about skipping a step, given how short the java code is. There was some talk about injecting that file into the fileset as an option for the aot task.

Was also thinking that this might be ncie

anyways, gotta go

Thanks @martinklepsch, that put me in the right direction, I think!

@jannis the pom task also accepts dependencies as an option, overriding the env ones

and you can have uber omit build dependencies if you make those build dependencies scope "test"

by default the uber task only includes dependencies of scope compile, runtime, and provided

generally it is sufficient to use scope test for all the build dependencies, the pom and uber etc will all work correctly then automatically

> if you make those build dependencies scope "test" This was a surprise to me!

Seems kind of magical / runs counter to 's philosophy.

it's really just the pom spec

not really a boot thing

@dominicm How does the boot-uberjar-example ensure my-namespace is available in the built uberjar (since it's not required anywhere other than in main.Main)? Is it the sift task?

the pom dependency scopes work correctly with any maven client

@jannis I believe it needs to be on your resource path, instead of your source path

Your code should only be in source-paths if you're aot'ing it

Oh! That would make sense.

https://github.com/adzerk-oss/boot-uberjar-example/blob/master/build.boot#L4

^^^ and if you don't want the source in the jar

Yep, that's probably it.

@micha: Ah! TIL. Thanks.

@micha Good point 🙂

both source and resource are on the class path, but source are excluded from packaging like jars

I remember that now. It's why all CLJS libraries have their sources in :resource-paths.

The trick with main.Main and javac is nice. However, it seems to also build .java sources from dependencies, generating duplicate classes and, thereby, a java compiler error.

I guess I should put javac before uber. Ah. Better.

Hm. And after all that, I get the Exception in thread "main" java.lang.ClassNotFoundException: java.util, compiling:(clojure/tools/reader/default_data_readers.clj:1:2) error at runtime, rather than during AOT. So it wasn't aot. I wonder what it is then.

java.util isn't a class

Yep. But somehow Clojure thinks it is when it sees that (:import [java.util Calendar ...]) line in tools.reader: https://github.com/clojure/tools.reader/blob/master/src/main/clojure/clojure/tools/reader/default_data_readers.clj#L12

No, it's probably not about that line.

I'm just not sure how to interpret the error message and where to look for the cause.

Seems like some kind of misdirection is going on here..

in a repl can you require the tools namespace?

the tools reader namespace

I'll try

Yep

The whole project starts and works fine if I run it from the REPL.

I add one dependency via merge-env! and aot fails. If I leave the dependency out it compiles fine.

Could it be a problem that this dependency is a Clojure project that was also pre-compiled with aot?

And that it doesn't include the sources in its JAR?

@jannis if you're only aot a namespace that has no :requires it shouldn't try to compile any other namespaces

That's not the problem here. I'm looking at "compile project X with aot, which depends on Y, which was also precompiled with aot". X doesn't even refer to Y anywhere in the code. It's just added as a dependency and it breaks aot compilation of X... I wish this project was open source and simpler, then I could share it.

are you sure you need to compile X?

although if X doesn't refer to Y there isn't any way that i can think of where they would interfere with each other

It is to be built into a standalone uberjar, so, yeah. I tried with the shim instead of aot but I get the same ClassNotFoundException: java.util error at runtime instead of at compile time that way. That's the only difference.

Hmm. Y is also an uberjar, perhaps that's the problem.

that looks to me like something is trying to import java.util, which isn't a class

it's a package

Yeah, no idea where that should be coming from...

uberjar in maven is highly unusual and definitely not recommended:)

it defeats all of the maven dependency machinery

and is almost impossible to debug

it's basically cloaking dependencies and snuggling them in under a different name and with no version info

smuggling even

highly likely that you'll see very strange bugs because of it

Yeah, hm. This is supposed to become a modular system, where each module can be executed as a standalone application but can also define code that can be imported into other projects.

that's OK you can have the dependencies separate

boy does this in fact

boot does this i mean

How do you mean?

phone autocorrect

boot ships with an uberjar inside of boot.jar

that uberjar contains all the maven stuff boy needs to resolve is own dependencies the first time you run it

like if you download boot.sh and have an empty maven cache

but that uberjar is constructed from normal maven dependencies

boot/pod, etc

point is that the uberjar is built from normal separate maven dependencies

it doesn't contain the modules itself except via its dependencies

put the module in a normal maven package and make a separate uberjar that depends on it

I was wondering what you meant but that last line is all I needed to know 😉

also having two uberjars on the class path at the same time is a recipe for madness

because they could contain conflicting classes

Yeah, that makes sense. Build one "library" jar and one "runtime" uberjar for each module basically.

Yeah, absolutely

exactly

Cool, thanks!

np!

hey guys.. can someone help me… I’m trying to serve stuff in ring handler from node_modules, what should I use? wrap-resource, wrap-file, something else?

what’s the right syntax?

can I combine use both wrap-resource and wrap-file?

can’t figure this out

@ag if your node_modules is in resource-paths you should be able to use wrap-resource only

but keep in mind that if you have #{"node_modules"} then boot/java will include the content within the folder only

I mean, you won't see the node_modules folder in there and wrap-resource should use "." as root path

ok… let me try, it never occurred to me to tweak resource-paths

you have two options actually, you could avoid that and use wrap-file as well

probably the latter is more easy to use as it does not clutter your mind with the resource trickery

my mind is already quite cluttered.

tried doing this: :resource-paths #{"resources" “n ode_modules”}. That hangs boot-clj

@ag try this:

(deftask add-node-modules []
  (with-pre-wrap fileset
    (let [nm (io/file "node_modules")]
      (when-not (and (.exists nm) (.isDirectory nm))
        (dosh "npm" "install" "react"))
      (-> fileset
        (add-resource (io/file ".") :include #{#"^node_modules/"})
        commit!))))

ok so probably because of the number of the files

ok see above ^ 😄

as @richiardiandrea said, you need to include "." to include node_modules

or else its contents will be included

@anmonteiro it looks like boot hangs before that even

now a word of caution: it's probably OK if you don't have a lot of modules, but you'll probably see substantial slow down in your build pipeline if you have a lot of modules

^ this is why I think your solution with io/file might be better

and wrap-file for serving

can someone give me insight on deraen.boot-sass I can’t figure out how to feed a single .sass file into it and get a single .css ?

or maybe there’s better alternative for sass in boot?

say you want a css/app.css on your class path, you need to add a folder with css/app.scss within :source-paths

alternately you can set :output-dir in your options for the sass task

oh, wait, I'm using mathias.boot-sassc, sorry

@richiardiandrea that’s the thing - it just grabs ALL sass files in the folder and tries to compile them. I need to tell it to pick up a single file.

@ag ok then I did not understand the issue in the first place 🙂 ..to pick one you would probably need to use sift with a regex and filter out the unwanted files...

pfff… migrating to boot turned out to be a lot more work than I initially expected… Kinda having hard time to convince my colleagues that this is still worthy effort

in this case tough, you have a bunch of scss files in the src-paths... it makes sense for the task to compile all of them right? can I ask you the reason why you want to pick one only?

also, I think that if you put an underscore as first character of the file name, it will be ignored

should be documented

@richiardiandrea yeah I found “_” thingy

needless to say; “I hate sass. Wish I could use Garden"

now this thing is trying to compile every sass/scss file it can lay hands on… remember my problem with npm? it’s trying to compile everying in node_modules… sigh

oh

java.lang.Exception: Error: File to import not found or unreadable: ../node_modules/rs-breakpoints/index.scss
                            Parent style sheet: /Users/ag.ibragimov/.boot/cache/tmp/Users/ag.ibragimov/DevProjects/finops-admin/1hwn/6qp7pj/node_modules/rs-golden-ratio-grid/sandbox/../src/index.scss
                             on line 2 of node_modules/rs-golden-ratio-grid/sandbox/../src/index.scss
                     >> @import '../node_modules/rs-breakpoints/index.scss';