you can remove the deref to make it not hang. I just added that to make the bb script not terminate

let's continue in thread

ok

I got this but nothing prints

Can you please try this in a standalone bb script and then execute it from the terminal?

Or clojure script if you are using this lib on the JVM

yes I will do this

it works nicely as a script

Perhaps try :out *out* in your editor for the last process in the pipeline

else, I don't know :)

I've tried this

but didn't change anything

ok, thank you for your time @borkdude! I will investigate on my own and let you know if I find something

nevemind, found it in the BBook )

^ @dennisa

Now tried it. This setting works:

"calva.replConnectSequences": [
        {
            "name": "bb",
            "projectType": "generic",
            "nReplPortFile": [".bb-nrepl-port"],
            "cljsType": "none"
        }
    ]

echo 1667 > .bb-nrepl-port && bb --nrepl-server

It won’t work for me. I can see ‘bb’ in the ‘connect to repl’ prompt but the port is still empty after localhost: The .bb-nrepl-port is created fine with 1667 port in it. @pez

And you are selecting bb, not just seeing it?

Also, which directory are you starting babashka in?

Yes, selecting. BB starts in the root dir or the project, where the repl file is.

Restarted VSC just in case

I now tried this on my Windows machine, and it just works there as well… Please file an issue about this using the Help menu in vscode. Attach the setting and the command line you are using.

It's on the mac. Do you want me to file issue to Microsoft about calva )? What's the chance to resolve it? )

The will forward me to the maker of the extension, at best

There is an option there to file the issue on the extension, so it will land in Calva’s GiHub repo. The point with doing it this way is that some system info will be attached to the issue.

How do you solve this in normal Clojure?

I'll brb

I solve this by making the farolero-signal artifact on maven that contains a single class that extends java.lang.Error (which extends from Throwable but not Exception), https://github.com/IGJoshua/farolero/blob/master/signal/src/farolero/signal/Signal.java Then in the actual farolero lib I just extend-protocol to this class to add the functionality for storing the objects that need to get passed around.

And the reason that it's in a different artifact altogether is to allow git dependencies on farolero.

@U5NCUG8NR So your library, does it catch only this specific exception and handle that one? Or does it install some global exception handler?

It only catches this one specific exception, and it never throws the exception except if it knows for a fact that it's currently in a dynamic context where it will be caught.

For the CLJS support it catches all objects thrown and re-throws them if they don't implement the protocol.

In particular there is exactly one construct that throws or catches this exception, and it is block, and everything else is implemented on top of that.

(block the-block
  (some code)
  (return-from the-block :returned)
  :unreachable)

In CLJS, can you throw any arbitrary object?

Yeah, it's a feature of JS.

A workaround I can come up with for bb is: Make one singleton Exception instance, e.g.:

(defonce FaroleroEx (Exception. "my-special"))

or just use ex-info with a special field in it to mark it as a farolero exception

I think that may just work best for bb

That's a good thought, I might do that. The key reason that I would want to throw arbitrary objects or something would just be to prevent catch blocks from interfering with this mechanism, but if I can't do that in bb, that's fine.

The features already won't be 100% parity anyway because I doubt bb implements locking and so the debugger won't be the same.

bb does implement locking

btw another thought. I see you mix specs with your code. If they are non-essential to your lib, e.g. only for development, I recommend putting them aside in a farolero.specs namespace so they can be optionally loaded. This saves startup time

bb currently doesn't come with clojure.spec.alpha since ... it's alpha

but there is https://github.com/borkdude/spartan.spec as a drop-in replacement

Oh, cool, maybe it can be on part with the debugger then. The main part I was concerned about is this highlighted portion: https://github.com/IGJoshua/farolero/blob/master/src/cljc/farolero/core.cljc#L1192-L1269 I guess it's worthwhile to see if it'll run unmodified on bb though. Thanks! As for the exception mechanism, I think I can just do what you suggested with an extra field on an ex-info

Oh, yeah, the specs. Good to know. The reason the specs are there is just to help with macroexpansion, they aren't used at runtime at all. Moving them to a separate namespace is far from out of the question.

Hmm, dosync and ref etc are not in babashka. Nobody ever asked for this. Those features were cool in the beginning of Clojure but nowadays pretty much everyone uses atoms

Yeah, this was the first time I'd ever found a use for refs.

What is the debugger object?

I might be able to refactor it to use atoms, but it could be a challenge, this is all pretty sensitive code and prone to race conditions on changes.

you call e.g. .wait and .notify on it, what is the type?

It's a unique cons of the condition and arguments.

line 1283

I don't think .wait and .notify currently work, but I think they could be made to work, with some work ;)

not sure how hard it is to port dosync etc

probably it's possible

Fair enough. I'd like to take a peek in the source of babashka/sci to see how hard adding notify and wait are. dosync etc I might be able to avoid by refactoring to use an atom, although we'll see if that ends up worth it.

oh gosh it does work already:

(locking 1 (.wait 1))

Oh nice!

Are numbers interned objects in bb?

hm, this didn't work:

user=> (def c (cons 1 2))
user=> (locking c (.wait c))
java.lang.IllegalArgumentException: No matching method wait found taking 0 args for class clojure.lang.PersistentList [at <repl>:1:8]

Are numbers interned: I don't do anything special with numbers, so I don't know

Ah, I see.

Yeah, I was able to get just a bare object to work as expected with wait and notify

user=> (identical? 1 1)
true

user=> (identical? 1 (+ 1 0))
true

Fair enough. Anyway, it looks like wait and notify don't work on clojure's collections, yeah, so that'd probably be where the work on wait and notify would have to be put.

I'm going afk now, as it's getting late. Let's revisit some other time and make issues for the things that could be examined / improved

Also I'm looking at this and while the ref code could be re-expressed in terms of atoms, it'd be clunky at best.

Sounds good!

btw, I think I know what the issue is. bb supports reflection on a selection of classes. e.g. this works:

user=> (def c (java.io.File. "foo"))
#'user/c
user=> (locking c (.wait c))

so if I add explicit support for a type then it should work

it just doesn't include the wait/notify methods for PersistentList

Fair enough. I'll make an issue for this now.

As well as a discussion issue about ref/dosync

:thumbsup:

As an aside, farolero kind of completed my personal trek through the multithreading facilities that clojure provides, since before this I'd used atoms of course, core.async channels, reducers, and agents for per-endpoint ratelimits on a discord client. Finally with farolero I've also used refs. Now I guess it's time for me to learn manifold, lol.

I think manifold could use some help, so that would be super cool

Honestly the one thing that I felt was really missing from core.async though was a promise channel that you could deref. So I've had to write one. 😛 https://github.com/IGJoshua/discljord/blob/master/src/discljord/util.clj#L93-L151

@U5NCUG8NR I've got dosync etc working. I'm also looking into .wait and .notify: this does work if you use an ^Object type hint, so you could try that as a workaround meanwhile.

I also made this GraalVM issue: https://github.com/oracle/graal/discussions/3456

If you want to try a binary with dosync etc, let me know your OS

Awesome, I'll give it a try today.

I'm using nixos

ok, then the static linux binary probably works for you: https://19891-201467090-gh.circle-artifacts.com/0/release/babashka-0.4.5-SNAPSHOT-linux-amd64-static.tar.gz

@borkdude the commute and alter functions would be great to have too. I know farolero uses at least alter. I'll get to actually testing it once my workday is done.

I already added alter. Adding commute now as well.

Thanks

@U5NCUG8NR Now the .notify / .wait stuff also works :)

https://19934-201467090-gh.circle-artifacts.com/0/release/babashka-0.4.5-SNAPSHOT-linux-amd64-static.tar.gz

$ time bb -e '(def x (cons 1 nil)) (locking x (.wait x 2000))'
bb -e '(def x (cons 1 nil)) (locking x (.wait x 2000))'   0.01s  user 0.01s system 1% cpu 2.033 total

I will just make a new release so you can use that

Thanks! Sorry I didn't get to try it out last night, life just kinda got in the way. Got a kitten recently and she requires a lot of attention.

No worries at all, I'm glad I got it working after all

and if you need something then we can just make another release

Sounds good