@tony.kay: Thanx, nice to hear other people have the same problem. BTW, what you mean by environment bug? You mean some bad combination of Cursive, figwheel etc?

@vmarcinko: Not sure. If I had a better idea I'd report it

can anyone else confirm that the master branch is not loading the client for todomvc? when I start both the server and client repls, I can run the test build, and the server is auto-reloading (fancy! thanks @currentoor), the client just doesn’t seem to want to show up on localhost:3000

Why is it trying to load the min file? This dev we're talking about right?

dev.html

index is now production build

@ethangracer: ^^^^

is that in the instructions?

ah, looks like that did get updated

thanks

yes it is in the instructions, i just didn’t catch it

How do the untangled people feel about sablono? https://github.com/r0man/sablono

like you can use it if you want

I wrote a macro that uses it to give a more concise syntax for defui.

Any chance you'd want to add that to untangled-client?

I won't be hurt if you say no.

We've gotten a lot of utility out of it so just thought I'd offer to add it here.

Ah, as in it uses sablano and also makes the factory?

yes

I don't really want sablano to be a required dep for UC

I'd be open to an untangled-sablano library

if there is enough utility to add to such a thing

So untangled-sablano could have the above macro?

right, and whatever else you think would be nice to have

for that concern

cool

you could own that, and we could ref your library from docs

that could work

as a note i’ve started building a defui “wrapper” here: https://github.com/untangled-web/untangled-client/blob/master/src/untangled/client/ui.clj https://github.com/untangled-web/untangled-client/blob/master/spec/untangled/client/ui_spec.clj https://github.com/untangled-web/untangled-client/blob/master/src/untangled/client/ui.cljs - I work with Tony @ Navis

also if/when you take a look, defui+ was a personal experiment

also I’m one of the few using vim & nrepl if anyone wants help on that

@mahinshaw was a major help, but he is using spacemacs

I’m happy to help anyone who wants to get figwheel running on emacs. There are also some great docs on the figwheel wiki:

https://github.com/bhauman/lein-figwheel/wiki/Using-the-Figwheel-REPL-within-NRepl#integration-with-emacscider

@currentoor: this defcomponent macro looks awesome!

@vmarcinko: thanks!

@adambros: do you have an example use of your wrapper?

ive had to switch tasks so all i have is the spec file its not very easy to read so here’s a snippet:

Hmm cool we've done some similar things!

the factory function trick specifically

defui+ was inspired by defscreen from https://github.com/oakes/play-clj

and i was going to tinker more with the look but got distracted by other tasks

the main focus of these defui's is to wrap the render method and have some devtools attached

I see, the main focus for me was making it less verbose and making the intent as clear as possible.

defui+ was that for me 😄

the idea for the devtools was to have a way to see what components are on screen, click to go to the source file, and even get their query onto a database overlay

haha nice i see you prepended ui as well

Oh fancy

yeah had conflicting symbols when i would destructure the result of a query

ah yes, that was what started our investigation of how to name factory functions

i had half jokingly suggested <comp>

lol nice

how’s untangled so far?

pretty good

i'm gonna do a code walk through with my manager later and if he gives the go ahead we'll use it for our product

nice!

well good luck

thanks!

just after tony told us he would open source, i joked that I “suddenly had the urge to clean up my code"

still feel that way 😅

that's good, shame + pride is one of the best motivators

not that there's anything shameful here!

most of my contributions are in untangled-spec, which was a hairball both internally and in how to use it

still feel shivers thinking about it

and i keep using it in every task, and wanting to tweak everything… i have to stop myself from switching and just writing down what i want to fix for later

yeah i know what you mean

I am also interested in this kind of "dev-time component middleware" (if you will) question

e.g. a highlight on rerender animation would be cool

I was thinking of just copying defui with a custom reshape map

defui in https://github.com/untangled-web/untangled-client/blob/master/src/untangled/client/ui.clj#L76 & wrap-render in https://github.com/untangled-web/untangled-client/blob/master/src/untangled/client/ui.cljs#L6 actually i’ve since updated wrap-render to work with figwheel’s source viewer

presumably untangled won't depend on react-motion, so how could I add my highlight animation? not reinventing mixins is on my mind

not sure what that is other than a react addon...

where are you trying to put that? (untangled or your app?)

well if the highlight-on-rerender goes into untangled, then my question (extensibility) goes away

kind of

i think @tony.kay might be your best bet on that, but id be interested in that functionality in a defui wrapper

Any suggestions for running migrations on an in memory test db manually? I'm using core.test and I wanted to run them on the setup part. Like so

to be clear I don't plan to use untangled soon (learning om.next by itself first before I look more closely at it) -- but interested in the general question of defui wrappers or other solutions

I guess for 'extensibility' one just creates a new defui wrapper which wraps the next wrapper down

@currentoor: i think https://github.com/untangled-web/untangled-datomic/blob/master/src/untangled/datomic/schema.clj#L224 is what we’re using internally to run the migration/schema

(io.rkn.conformity/ensure-conforms dbconnection migration)

i’d imagine that’s what you’d want

I'm wondering about expressing the various dev-time middleware as separate components which take children, then just having dev-time factories wrap their results in those components

is it bad somehow to have extra dev-time components in the tree?

I guess for stuff like *cljs-file* we do need some more magic

if you can elide the dev-time during production, i dont see the issue if you are careful about being a transparent wrapper

im planning on doing that by using config

or a System/getenv

guess what I'm wondering is how to create transparent wrappers. I'll experiment..

id think a defn or a defui with only a render method would do

but i think you need to pass it the right this or props

@adambros: thanks I'll check it out!

@tomjack: Dev time concerns are of interest to us, as @adambros said. Highlight on rerender as a dev time option would be nice...as would click to jump to source, db panel, etc. We'll want to define the set we're looking for (feature-wise) and just start chipping away.

I also encourage ppl to think about their real desired outcome, not just a suggested implementation. E.g. highlight on re-render is presumably to debug things not getting re-rendered...might be better ways of debugging that.

I was thinking of knowing when too much is getting rerendered

but my real interest is in the general problem -- a handy defui dev wrapper which does a fixed set of things would only be moderately interesting to me

Well, more of a general Om topic then....what, exactly, are you looking for?

transparent wrapper of what?

render? What's wrong with a function

lifecycle? Delegation comes to mind

Syntactic sugar? Cljs macros

yeah, it's a general om problem. just happened to see a related non-solution float by here

well, it's not actually clear that untangled.client.ui/defui is not a solution

I can just copy it into my project and add whatever stuff I want

Right...custom macro.

Hi, I'm still having trouble getting the db setup for a test working. I'm trying this, am I even on the right track

Or is it not a good idea to use build-database in my test setup?

build-database is a component....

let me think....I'm on a Java thing right now...switching gears

@ethangracer: You're working on tests, right? Remind me what we're doing for database setup in integration tests

oh, right...`with-db-fixture`, right?

@tony.kay @currentoor : to write tests against the database i’ve been using untangled.datomic.test-helpers/with-db-fixture)

yes

now I think @currentoor is looking to test migrations

not sure if with-db-fixture is the place to do that

Um...testing migrations isn't an automated thing so much as proven by the fact that the rest of your integration tests pass

testing behaviors, not facts

@currentoor: ^^^^

No one should give a rats ass if your migrations fact-check...given that if the real behaviors don't work, then you're SOL anyway

So, do real behavioral integration tests if you want to know your db is correct.

schema is right only when the app works

This was the original question https://clojurians.slack.com/archives/untangled/p1459803905000694

Oh I don't want to test migrations, I just wanted to run my tests on a migrated database

Yeah....`with-db-fixture`

that sets up a db, runs migrations, gives you connection

as a wrapper

like a let block

with-db-fixture is a beautiful thing

let me know if you’d like some sample code

we also have with-system, I believe

awesome! yes please, @ethangracer

sorry..need more docs on this stuff It is a pretty complete set of tools 😉

lol no worries, takes time

@currentoor: give me a few to pull one together

thanks a million!

@ethangracer: I'm ok with you showing him a production test

planning on it, just want to clean up some variable names for context

@currentoor: We also have protocol testing, which is for writing tests that ensure the complete round-trip is correct

@tony.kay: yeah I started reading your writeup about that, fancy stuff.

you saw this: https://github.com/awkay/protocol-testing/blob/master/ProtocolTesting.md

yup

that was the initial draft of the idea...it is implemented now

oh cool

it isn't exactly like the doc, but it is there

I included a helper function, db-fixture-defs which helps with testing

essentially, you pass a symbol name that becomes a database component — that component is seeded using the migrations in the directory specified by the string after :migrations, and is seeded using the :seed-fn, which for us uses link-and-load-seed-data

@currentoor: Have you seen the seeding tempid support?

from the todo-mvc app?

no...in our testing code

oh, nope

In the code he just shared: :

is a placeholder for a datomic ID...you get back a map from those to the real ids after seeding

his helper gives you back a get-id function

(get-id :) would return the real ID it got assigned on seeding

Makes it trivial to write db tests

with arbitrary seeding

hmm, thanks i'll look into that later today

i just double checked, I don’t have an example that doesn’t make extensive use of our helpers

right now I'm getting "Assert failed: :mockdb has no Schema in dbs of app config." when i try to use with-db-fixture

how do i specify the config for the db created by with-db-fixture?

name it after your production db, which is alrady configured

on your local machine, your config file points to a dev db or in-memory db

If you want, you could add an additional config section

:report-center is the name of your db

so are you saying I should do (with-db-fixture report-center ...)?

yes, I think so

hmm i'll restart my repl but that doesn't seem to be workign

no, changing the name of the symbol won’t matter

right, not the symbol

you have to specify the correct :migrations directory

that’s the only thing I imagine would be causing your error

right..it needs no config...forgot

:migrations and :seed-fn

:migrations is required, :seed-fn is optional but recommended

where do i add these entries?

at the bottom of the with-db-fixture form

it’s included in the snippet but kind of hard to see

oh, didn't notice that 😄

the basic format is (with-db-fixture pick-a-name-here (form to evaluate and write tests here) :migrations “app.migrations.package” :seed-fn (call me to seed the database)

cool, it works now!

thanks guys

wohoo!