Upgrading to this version today in our dev environment. 👍

hello, I'm getting the following error when going from 2.24.0 to 2.25.0:

Closure compilation failed with 2 errors
--- node_modules/primereact/primereact.all.esm.js:9270
Dynamic import expressions cannot be transpiled.
--- node_modules/primereact/primereact.all.esm.js:17407
Dynamic import expressions cannot be transpiled.

├── [email protected]

ok that one is sort of expected. it never really worked, it just failed silently and blows up at runtime

gotta love libs that do build tool specific things in their code 😛

import('quill').then(function (module) {
          if (module && DomHandler.isExist(contentRef.current)) {
            if (module["default"]) {
              // webpack
              quill.current = new module["default"](contentRef.current, configuration);
            } else {
              // parceljs
              quill.current = new module(contentRef.current, configuration);
            }
            initQuill();
          }

I'll see about making it fail silently again I guess? let me think about it. thanks for the report.

oh so it's stuff I'm not using ? Is there a way to exclude those items ?

potentially. if you use (:require ["primereact" :as p]) and then p/Accordion or :refer (Accordion) consider using (:require ["primereact/accordion" :as Accordion]) instead

(:require ["primereact" :as p]) will include every single component and make the build rather large

you can selectively require only the components you need instead

https://www.npmjs.com/package/primereact?activeTab=code

each dir there appears to be one component and at least the editor is the one trying the dynamic require from above

so if you don't use that you won't get the error

thanks, yes we were requiring the .all.esm module to convert the components, we'll change that

better than crashing at runtime at some point in the future when we start using stuff !

FYI: I just updated and found no issues. 👍

I get

{:op :eval-compile-error, :ex-client-id 1, :ex-oid "8ec63e28-c811-4b33-a335-d0b49b631128", :report "[line 1, col 34] Unexpected EOF while reading item 1 of list, starting at line 1 and column 1.\n", :from 36}

After

{:op :cljs-eval :to 36 :input {:code "(do; #\"regex\" #'some-invalid-var)" :ns 'cljs.user}}

note sure how you'd get to the regexp error since this is an EOF error? the form is incomplete?

in general shadow.remote will never send any object over the wire as transit? not sure how you are getting it to that point?

you get the :ex-oid which you can then request as edn, str, etc but not transit?

using shadow.remote is fine, just lacking documentation 😛

ah I suspect you just sent {:op :cljs-eval :to 36 :input {:code (do; #"regex" #'some-invalid-var) :ns 'cljs.user}} or some form of it over the websocket? ie. :code as not a string but the actual "form"?

I'd suspect that would blow up in various forms since it already fails at the websocket read, so well before even getting to shadow.remote?

I don't have a test setup to send invalid edn, so thats a guess? 😛

Oh, sorry!

I sent the invalid form, that ; is a test I was doing

The right OP should be: {:op :cljs-eval :to 36 :input {:code "(do #\"regex\" #'some-invalid-var)" :ns 'cljs.user}}

ah yes, that reproduces.

fixed in 2.25.1